This repository has been archived by the owner on Jul 24, 2024. It is now read-only.
Fix credential-based microsoft authentication #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the request to the login route fails (due to whatever reason), the header is missing and calling String.join would invoke List#get on a null-list. Just fallback to an empty list.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set-Cookieheaders in their response, which this change now respects.oauth20_token.srf-Route is invalid and should be equal to the one from the login endpoint (otherwise the granted code is invalid due to different environments)MsAuthenticationService#getLoginResponseFromCreds(No need for deprecation as this method is private either way)Fixes Microsoft authentication with username and password not working #27