fixup! delete ns_vec members in reverse

Gnucash · Aug 27, 2024 · f25aa84 · f25aa84
1 parent dd8617c
commit f25aa84
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/libgnucash/engine/gnc-commodity.cpp b/libgnucash/engine/gnc-commodity.cpp
@@ -2198,8 +2198,11 @@ gnc_commodity_table_destroy(gnc_commodity_table * t)
     if (!t) return;
     ENTER ("table=%p", t);
 
-    for (auto ns : t->ns_vec)
+    for (auto it = t->ns_vec.rbegin(); it != t->ns_vec.rend(); ++it)
+    {
+        auto ns{*it};
         gnc_commodity_table_delete_namespace(t, ns->name);
+    }
 
     t->ns_vec.~CommNSVec ();
     t->ns_table.~StringCommNSMap ();