Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: remove resource-summary audit #15299

Merged
merged 5 commits into from
Aug 3, 2023
Merged

core: remove resource-summary audit #15299

merged 5 commits into from
Aug 3, 2023

Conversation

adamraine
Copy link
Member

Part of #14909
Alternative to #15286

After discussion, we are definitely keeping total-byte-weight as an audit instead of resource-summary. The question now becomes, do we want to add the resource summary table to total-byte-weight? Perhaps not if we plan on removing budgets in the near future #15203.

This PR is the simplest approach to merging total-byte-weight and resource-summary which is to just remove resource-summary.

@connorjclark
Copy link
Collaborator

Reviewer note: w/ this PR and #15203, we can also remove core/computed/resource-summary.js.

@adamraine adamraine merged commit dfe6fb9 into main Aug 3, 2023
27 checks passed
@adamraine adamraine deleted the rm-resource-summary branch August 3, 2023 18:35
@mohan-murali
Copy link

We were using few fields from the resource-summary. What will be the best alternative that you will suggest?

@adamraine
Copy link
Member Author

The hidden network-requests audit should contain all the network requests along with the transfer size, resource size, and resource type. You will need to do the aggregation yourself though.

@mohan-murali
Copy link

Thanks! I was dreading looping through all the data. I guess there are no other options.

@MOMs69

This comment was marked as spam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants