Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests(smoke): allow for decimal in a11y tap target #15327

Merged
merged 1 commit into from
Aug 2, 2023
Merged

Conversation

connorjclark
Copy link
Collaborator

in smokerider we get this:

✘ difference at target-size audit.details.items[0].node.explanation
expected: "/^Fix any of the following:\n {2}Target has insufficient size \([0-9]+px by [0-9]+px, should be at least 24px by 24px\)\n {2}Target has insufficient offset from its closest neighbor \([0-9]+px should be at least 24px\)$/"
found: "Fix any of the following:\n Target has insufficient size (8.9px by 17px, should be at least 24px by 24px)\n Target has insufficient offset from its closest neighbor (13.4px should be at least 24px)"

@connorjclark connorjclark requested a review from a team as a code owner August 2, 2023 21:15
@connorjclark connorjclark requested review from brendankenny and removed request for a team August 2, 2023 21:15
@connorjclark connorjclark merged commit 691c506 into main Aug 2, 2023
27 checks passed
@connorjclark connorjclark deleted the a11y-smoke-dec branch August 2, 2023 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants