core(image-aspect-ratio): loosen aspect ratio threshold #15328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorjclark
reviewed
Aug 2, 2023
| @@ -59,7 +60,9 @@ class ImageAspectRatio extends Audit { | |||
| const displayedAspectRatio = image.displayedWidth / image.displayedHeight; | |||
|
|
|||
| const targetDisplayHeight = image.displayedWidth / actualAspectRatio; | |||
There was a problem hiding this comment.
I don't think we need a threshold ratio. Could we just Math.min/max (don't make me engage my brain to determine which way right now :P ...) image.displayedWidth / actualAspectRatio?
I'm thinking that 0.01 is pretty arbitrary and possibly leaves the general case unsolved.
connorjclark
approved these changes
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #15326