new_audit: use a strong HSTS policy #16257
Open
+1,274
−268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… update:sample-json.
… into hsts-audit
adamraine
changed the title
adamraine
reviewed
Nov 19, 2024
adamraine
reviewed
Nov 19, 2024
… Also hide the result from the report UI.
sebastian9er
added a commit
to sebastian9er/lighthouse
that referenced
this pull request
Nov 21, 2024
adamraine
reviewed
Nov 21, 2024
adamraine
reviewed
Nov 21, 2024
adamraine
reviewed
Nov 21, 2024
…il docs are published, some text phrasings and the smoke test assertions.
adamraine
approved these changes
Nov 22, 2024
| /** Summary text for the results of a Lighthouse audit that evaluates the HSTS header. This is displayed if no HSTS header is deployed. "HSTS" stands for "HTTP Strict Transport Security". */ | ||
| noHsts: 'No HSTS header found', | ||
| /** Summary text for the results of a Lighthouse audit that evaluates the HSTS header. This is displayed if the preload directive is missing. "HSTS" stands for "HTTP Strict Transport Security". */ | ||
| noPreload: 'No preload directive found', |
There was a problem hiding this comment.
Suggested change
| noPreload: 'No preload directive found', | |
| noPreload: 'No `preload` directive found', |
| /** Summary text for the results of a Lighthouse audit that evaluates the HSTS header. This is displayed if the preload directive is missing. "HSTS" stands for "HTTP Strict Transport Security". */ | ||
| noPreload: 'No preload directive found', | ||
| /** Summary text for the results of a Lighthouse audit that evaluates the HSTS header. This is displayed if the includeSubDomains directive is missing. "HSTS" stands for "HTTP Strict Transport Security". */ | ||
| noSubdomain: 'No includeSubDomains directive found', |
There was a problem hiding this comment.
Suggested change
| noSubdomain: 'No includeSubDomains directive found', | |
| noSubdomain: 'No `includeSubDomains` directive found', |
| /** Summary text for the results of a Lighthouse audit that evaluates the HSTS header. This is displayed if the includeSubDomains directive is missing. "HSTS" stands for "HTTP Strict Transport Security". */ | ||
| noSubdomain: 'No includeSubDomains directive found', | ||
| /** Summary text for the results of a Lighthouse audit that evaluates the HSTS header. This is displayed if the max-age directive is missing. "HSTS" stands for "HTTP Strict Transport Security". */ | ||
| noMaxAge: 'No max-age directive', |
There was a problem hiding this comment.
Suggested change
| noMaxAge: 'No max-age directive', | |
| noMaxAge: 'No `max-age` directive', |
| /** Summary text for the results of a Lighthouse audit that evaluates the HSTS header. This is displayed if the max-age directive is missing. "HSTS" stands for "HTTP Strict Transport Security". */ | ||
| noMaxAge: 'No max-age directive', | ||
| /** Summary text for the results of a Lighthouse audit that evaluates the HSTS header. This is displayed if the provided duration for the max-age directive is too low. "HSTS" stands for "HTTP Strict Transport Security". */ | ||
| lowMaxAge: 'max-age is too low', |
There was a problem hiding this comment.
Suggested change
| lowMaxAge: 'max-age is too low', | |
| lowMaxAge: '`max-age` is too low', |
| title: 'Use a strong HSTS policy', | ||
| /** Description of a Lighthouse audit that evaluates the security of a page's HSTS header. This is displayed after a user expands the section to see more. No character length limits. The last sentence starting with 'Learn' becomes link text to additional documentation. "HSTS" stands for "HTTP Strict Transport Security". */ | ||
| description: 'Deployment of the HSTS header significantly ' + | ||
| 'reduces the risk of downgrading of and eavesdropping attacks on HTTP connections. ' + |
There was a problem hiding this comment.
Suggested change
| 'reduces the risk of downgrading of and eavesdropping attacks on HTTP connections. ' + | |
| 'reduces the risk of downgrading HTTP connections and eavesdropping attacks. ' + |
| scoreDisplayMode: Audit.SCORING_MODES.INFORMATIVE, | ||
| title: str_(UIStrings.title), | ||
| description: str_(UIStrings.description), | ||
| requiredArtifacts: ['devtoolsLogs', 'URL'], |
There was a problem hiding this comment.
Since we are only looking at the main document, this audit is only relevant to page navigations.
Suggested change
| requiredArtifacts: ['devtoolsLogs', 'URL'], | |
| requiredArtifacts: ['devtoolsLogs', 'URL'], | |
| supportedModes: ['navigation'], |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adding a new audit to Ligththouse, which detects deviations from an optimal HSTS header deployment.
Part of a larger change to introduce more similar header deployments.
Link to documentation is pending internal discussions (@adamraine FYI, either of us can update the Link here once we have the blog post done).