base64 encode deferred payloads for better compatibility #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phil-lopreiato
added a commit
to the-blue-alliance/the-blue-alliance
that referenced
this pull request
Jan 1, 2022
This pins us to a forked version of the GAE library, as a way to work around GoogleCloudPlatform/appengine-python-standard#45 This package is running the changes from GoogleCloudPlatform/appengine-python-standard#46 so we can base64 encode all the deferred payload before attempting to execute them. This one was fun to track down...
|
This seems to have been fixed in the SDK, so no need for this |
|
Well, since I reopened #45 (and this entire problem seems fraught until the SDK fully supports python3), this approach might still be worthwhile? |
phil-lopreiato
force-pushed
the
b64-deferred
branch
from
0330577 to
413af5f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One way to fix #45
I'm not sure this is exactly the right behavior when it comes to all permutations of compatibility the library wants to main, but I'd be happy to tweak this around (or gate with another env var, or something)