Fix polymodel class_ type inconsistency (#89) #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
spiqueras
commented
Jul 3, 2023
| @@ -193,7 +193,7 @@ def _update_kind_map(cls): | |||
| cls._kind_map[cls._class_name()] = cls | |||
| class_key = cls._class_key() | |||
| if class_key: | |||
| cls._class_map[tuple(class_key)] = cls | |||
| cls._class_map[tuple(map(six.ensure_binary, class_key))] = cls | |||
There was a problem hiding this comment.
I've gone with six.ensure_binary because that's what _class_key was using.
Given the library isn't PY2-compatible and assuming _class_key always returns a list of str, a lambda should be faster:
Suggested change
| cls._class_map[tuple(map(six.ensure_binary, class_key))] = cls | |
| cls._class_map[tuple(map(lambda c: c.encode(), class_key))] = cls |
spiqueras
force-pushed
the
polymodel-class-name
branch
from
beb333e to
a905b13
Compare
|
Gentle ping. Is there anything I can do to move this forward? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #89 by modifying the return type of
class_map_to always return a list of strings[ ] Appropriate changes to README are included in PR(not applicable)