feat: introduce optional resolve_references method
#206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows for easier implementation of batch loading when resolving federated entities
col
force-pushed
the
resolve_reference_data_loading
branch
from
e609105
to
3f84596
Compare
geshwho
reviewed
Aug 22, 2022
|
@col Thank you for the PR! This is looking pretty good to me. |
geshwho
changed the title
resolve_references methodresolve_references method
Co-authored-by: Mangesh Tamhankar <[email protected]>
geshwho
approved these changes
Aug 24, 2022
rylanc
pushed a commit
that referenced
this pull request
Aug 24, 2022
# [3.3.0](v3.2.0...v3.3.0) (2022-08-24) ### Features * introduce optional `resolve_references` method ([#206](#206)) ([1e3b631](1e3b631))
|
🎉 This PR is included in version 3.3.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This was referenced Feb 23, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses the issues with using data loader in the existing
resolve_referencemethod. (See: #205)By grouping all the references of the same type into a single call to
resolve_referencesthe records can more easily be loaded as a batch. This can be done using a data loader (.load_all) or just a direct DB query as all the references are provided in a single method call.The existing
resolve_referencemethod is still supported butresolve_referenceswill be the preferred approach.