Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added support for windows file paths #60

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ribsey
Copy link

@ribsey ribsey commented Nov 29, 2022

I encountered a library with windows file paths and some of them had even the current working directory during the build added in front of the file path, like this:
D:\\stack\\targets\\ST\\STM32F0/HW-Abstraction.c:122
or this:
D:\\some\\other\\path\\D:\\stack\\targets\\ST\\STM32F0/HW-Abstraction.c:122

So with the new regex and the backslash to slash replacement, these paths get parsed as well.

and some paths, where the current directory was added befor the file path (only seen with windows paths)
@HBehrens
Copy link
Owner

Thank you for providing some more real-world data into the mix and providing a matching implementation, @ribsey 💪

@noahp I haven't look at the code in a while, do you know if this part does have tests already? With all of this regex shenanigans, I am worried we will (one day) introduce a regression during the attempt to add more features. If yes, adding the examples provided would be awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants