Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correcting req.body of GetAdmins api #883 #884

Merged
merged 2 commits into from
May 15, 2024

Conversation

SwayamRana808
Copy link
Contributor

@SwayamRana808 SwayamRana808 commented May 15, 2024

Issue that this pull request solves

Closes: #883

Proposed changes

changed email body param to query param and getAdminValidation schema to include email as query

Brief description of what is fixed or changed

get route taking body req now it is query req

Types of changes

Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (Documentation content changed)
  • Other (please describe):

Checklist

Put an x in the boxes that apply

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • My changes does not break the current system and it passes all the current test cases.

Screenshots

Please attach the screenshots of the changes made in case of change in user interface

Other information

Any other information that is important to this pull request

@auto-assign auto-assign bot requested a review from jackfrost13 May 15, 2024 14:30
@Kajol-Kumari Kajol-Kumari requested review from Kajol-Kumari and removed request for jackfrost13 May 15, 2024 14:42
@Kajol-Kumari Kajol-Kumari added level1 Wiki or Major Documentation work. gssoc GSSoC'24 Label labels May 15, 2024
@SwayamRana808 SwayamRana808 changed the title Correcting req.body of GetAdmins api #883 Correcting req.body of GetAdmins api #884 May 15, 2024
@SwayamRana808 SwayamRana808 changed the title Correcting req.body of GetAdmins api #884 Correcting req.body of GetAdmins api #883 May 15, 2024
@Kajol-Kumari Kajol-Kumari merged commit 9891bf9 into HITK-TECH-Community:main May 15, 2024
7 checks passed
@SwayamRana808 SwayamRana808 deleted the getApi branch May 16, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc GSSoC'24 Label level1 Wiki or Major Documentation work.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Correcting req.body of GetAdmins api
2 participants