Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Frontend] Integrate Add Team Member API with Frontend Fixed #891

Merged
merged 2 commits into from
May 16, 2024

Conversation

Hemu21
Copy link
Contributor

@Hemu21 Hemu21 commented May 15, 2024

Issue that this pull request solves

Issue Link

Closes: #725

Brief description of what is fixed or changed

I had changed the addteamMembers file and about file and fixed 2 issues one is add team members. and anotherone is while running in localhost when you click on the add teammembers it will redirect but you unable to add the data or any function doesn't works I fixed it. and tested the addteammembers is working now.

Steps to test

  • go to add team members
  • try to add the data. If you get success message.
  • Then goto manage team and scroll to last then check that data is added or not.

Types of changes

Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (Documentation content changed)
  • Other (please describe):

Checklist

Put an x in the boxes that apply

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • My changes does not break the current system and it passes all the current test cases.

@Hemu21
Copy link
Contributor Author

Hemu21 commented May 15, 2024

@Kajol-Kumari Can you please check my PR and merge it.

@@ -316,6 +347,12 @@ export function AddTeamMember() {
handleCloseToast={handleCloseToast}
severity="success"
/>
<SimpleToast
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please modify this to be generic i.e if the api is success, it should show success message and if api fails, it should show error message. please take reference from - https://github.com/HITK-TECH-Community/Community-Website/blob/main/frontend/src/pages/ContactUs/ContactUs.jsx#L324-L328

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, when i am adding the member using ui, the image isn't appearing in the fetched list, please look into that as well, its a level3 issue, i expect it to be working e2e.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok I will update it with generic one.

@Hemu21
Copy link
Contributor Author

Hemu21 commented May 16, 2024

@Kajol-Kumari updated can you please check it.

@Kajol-Kumari Kajol-Kumari added level3 New features, major bug fixing. gssoc GSSoC'24 Label labels May 16, 2024
@Kajol-Kumari Kajol-Kumari merged commit b0cc517 into HITK-TECH-Community:main May 16, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc GSSoC'24 Label level3 New features, major bug fixing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Frontend] Integrate Add Team Member API with Frontend
2 participants