Backend Get q&A using ID #906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -14,7 +14,7 @@ | |||
| router.get('/getallquestions', getAllQuestion); | |||
|
|
|||
| // This route will give question by given id | |||
| router.get('/getQuestionById', getQuestionById); | |||
| router.get('/getQuestionById/:questionId', getQuestionById); | |||
Check failure
Code scanning / CodeQL
Missing rate limiting High
|
@Kajol-Kumari can you please check this |
Kajol-Kumari
requested changes
May 16, 2024
| @@ -5,7 +5,7 @@ const { ErrorHandler } = require('../../../../helpers/error'); | |||
| const constants = require('../../../../constants'); | |||
|
|
|||
| module.exports = async (req, res, next) => { | |||
| const qId = req.body.question_id; | |||
| const qId = req.params.id; | |||
There was a problem hiding this comment.
what id it denotes? can you name it properly questionId or answerId
| @@ -12,7 +12,7 @@ const updateAnswerStatus = require('./updateAnswerStatus'); | |||
| router.post('/', validation(answerValidationSchema), postAnswer); | |||
|
|
|||
| // GET API FOR ANSWERS | |||
| router.get('/', validation(getAnswerValidationSchema), getAnswers); | |||
| router.get('/:id', validation(getAnswerValidationSchema), getAnswers); | |||
|
@Kajol-Kumari updated can you please check |
Kajol-Kumari
approved these changes
May 16, 2024
Kajol-Kumari
added
level1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue that this pull request solves
Issue Link resolve #905
Closes: #905
Brief description of what is fixed or changed
I made the router to dynamic and get that data from params. backend is fixed.
Types of changes
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply