-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DRAFT: Update maintenance to all stops in stop area #962
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 7 files reviewed, 1 unresolved discussion (waiting on @suvikankare)
ui/src/components/stop-registry/stop-areas/stop-area-details/useGetStopAreaDetails.ts
line 17 at r1 (raw file):
} query getAllStopAreas {
Ei 🛑 Alueita on vähintäänkin 2000kpl
Oikea tapa selvitää kaikki sisarpysäkit on tyyliin:
stop_registry {
stopPlace(id: pysäkionId) { # Nykynen pysäkki
groups: { # Sen pysäkki alue(et)
members: { id } # Tän + sisarpyäskkien ID:T
}
}
}
`
263d32f
to
998b9ca
Compare
998b9ca
to
90cb74e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 9 files reviewed, 1 unresolved discussion (waiting on @Huulivoide)
ui/src/components/stop-registry/stop-areas/stop-area-details/useGetStopAreaDetails.ts
line 17 at r1 (raw file):
Previously, Huulivoide (Jesse Jaara) wrote…
Ei 🛑 Alueita on vähintäänkin 2000kpl
Oikea tapa selvitää kaikki sisarpysäkit on tyyliin:
stop_registry { stopPlace(id: pysäkionId) { # Nykynen pysäkki groups: { # Sen pysäkki alue(et) members: { id } # Tän + sisarpyäskkien ID:T } } } `
Logiikka muutettu ✔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 7 files at r1, 5 of 6 files at r2, all commit messages.
Reviewable status: 8 of 9 files reviewed, 1 unresolved discussion (waiting on @suvikankare)
ui/src/components/stop-registry/stop-areas/stop-area-details/useGetStopAreaDetails.ts
line 17 at r1 (raw file):
Previously, suvikankare wrote…
Logiikka muutettu ✔
Mutta sanosin että nää uudet jutut pitäs nyt pistää kokonaan eri tiedostoon. Koska nää on kaks ihan eri kyselyä.
Myöskin, jos jo etukäteen olis tiedossa pysäkkialueen ID, niinku tulee oleen viimeistään sen toisen uuden "Näytetään pysäkkialueen tiedot Pysäkin tietosivulla" -tiketin jälkeen. Niin ei tarvi hypätä pysäkin kautta vaan voi suoraan vaan kysellä groupOfStopPlace(id; stopAreaId) { memberStops { id } }
. Eli sinne vois pysökin tietojen haku kyselyyn listätä ton alueen id kentän mukaan.
How to test:
Search for stop areas
Select stop
Navigate to Tekniset ominaisuudet -> Ylläpito
Edit all the fields
Go to another stop in the stop area
Check that Pysäkkialueen kunnossapito is now the same as you set in the other stop
Check that other fields have not changed
TODO:
e2e
This change is