Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Privacy 2024 Chapter #3817

Draft
wants to merge 148 commits into
base: main
Choose a base branch
from
Draft

Privacy 2024 Chapter #3817

wants to merge 148 commits into from

Conversation

max-ostapenko
Copy link
Contributor

@max-ostapenko max-ostapenko commented Oct 28, 2024 •
edited
Loading

Fixes #3603

Staged link: https://privacy-2024-dot-webalmanac.uk.r.appspot.com/en/2024/privacy
Staged featured chapter home page link: https://privacy-2024-dot-webalmanac.uk.r.appspot.com/en/2024/?feat=privacy

  • Add chapter metadata (contributors, bios, featured)
  • Add markdown code and review it
  • Add figures markdowns

max-ostapenko and others added 30 commits May 3, 2024 16:37
@max-ostapenko
readme
251654f
@max-ostapenko
copied 2022 SQLs over to update/review
537aa53
@max-ostapenko
fixed link
237a280
@max-ostapenko
origin trials
66cccb2
@dependabot @max-ostapenko
Bump puppeteer from 22.7.1 to 22.8.0 in /src (#3655)
736a7ab 
Bumps [puppeteer](https://github.com/puppeteer/puppeteer) from 22.7.1 to 22.8.0.
- [Release notes](https://github.com/puppeteer/puppeteer/releases)
- [Changelog](https://github.com/puppeteer/puppeteer/blob/main/release-please-config.json)
- [Commits](puppeteer/puppeteer@puppeteer-v22.7.1...puppeteer-v22.8.0)

---
updated-dependencies:
- dependency-name: puppeteer
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@max-ostapenko
notebook + readme (#3652)
86506a3
@dependabot @max-ostapenko
Bump pytest from 8.1.1 to 8.2.0 in /src (#3651)
99aee63 
Bumps [pytest](https://github.com/pytest-dev/pytest) from 8.1.1 to 8.2.0.
- [Release notes](https://github.com/pytest-dev/pytest/releases)
- [Changelog](https://github.com/pytest-dev/pytest/blob/main/CHANGELOG.rst)
- [Commits](pytest-dev/pytest@8.1.1...8.2.0)

---
updated-dependencies:
- dependency-name: pytest
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@ksakae1216 @max-ostapenko
Translation of privacy chapter to Japanese (#3654)
f76f679
@github-actions @tunetheweb @max-ostapenko
Update Timestamps (#3657)
c29735a 
Co-authored-by: tunetheweb <[email protected]>
@rviscomi @max-ostapenko
2023 Performance (#3525)
47811ca 
* cp 2022->2023

* 2023ify

* 2023/perf

* lint

* lint

* fix initiator

* null initiators
@dependabot @max-ostapenko
Bump puppeteer from 22.8.0 to 22.9.0 in /src (#3662)
46dabdc 
Bumps [puppeteer](https://github.com/puppeteer/puppeteer) from 22.8.0 to 22.9.0.
- [Release notes](https://github.com/puppeteer/puppeteer/releases)
- [Changelog](https://github.com/puppeteer/puppeteer/blob/main/release-please-config.json)
- [Commits](puppeteer/puppeteer@puppeteer-v22.8.0...puppeteer-v22.9.0)

---
updated-dependencies:
- dependency-name: puppeteer
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@rviscomi @tunetheweb @max-ostapenko
Upgrade to web-vitals v4 (#3661)
743f560 
* Upgrade to web-vitals v4

* Update src/static/js/send-web-vitals.js

Co-authored-by: Barry Pollard <[email protected]>

---------

Co-authored-by: Barry Pollard <[email protected]>
@dependabot @max-ostapenko
Bump pytest from 8.2.0 to 8.2.1 in /src (#3664)
0983d6c 
Bumps [pytest](https://github.com/pytest-dev/pytest) from 8.2.0 to 8.2.1.
- [Release notes](https://github.com/pytest-dev/pytest/releases)
- [Changelog](https://github.com/pytest-dev/pytest/blob/main/CHANGELOG.rst)
- [Commits](pytest-dev/pytest@8.2.0...8.2.1)

---
updated-dependencies:
- dependency-name: pytest
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @max-ostapenko
--- (#3665)
42e4599 
updated-dependencies:
- dependency-name: web-vitals
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @max-ostapenko
Bump puppeteer from 22.9.0 to 22.10.0 in /src (#3668)
22ec347 
Bumps [puppeteer](https://github.com/puppeteer/puppeteer) from 22.9.0 to 22.10.0.
- [Release notes](https://github.com/puppeteer/puppeteer/releases)
- [Changelog](https://github.com/puppeteer/puppeteer/blob/main/release-please-config.json)
- [Commits](puppeteer/puppeteer@puppeteer-v22.9.0...puppeteer-v22.10.0)

---
updated-dependencies:
- dependency-name: puppeteer
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @max-ostapenko
Bump jsdom from 24.0.0 to 24.1.0 in /src (#3669)
1eb5873 
Bumps [jsdom](https://github.com/jsdom/jsdom) from 24.0.0 to 24.1.0.
- [Release notes](https://github.com/jsdom/jsdom/releases)
- [Changelog](https://github.com/jsdom/jsdom/blob/main/Changelog.md)
- [Commits](jsdom/jsdom@24.0.0...24.1.0)

---
updated-dependencies:
- dependency-name: jsdom
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@borisschapira @max-ostapenko
Typofix (#3670)
c566929 
Seems like "desktop" is mentioned twice and according to the data, the second mention is related to mobile https://docs.google.com/spreadsheets/d/1JvJMiRsL6T9m_NEBHFh-rrQmU5a-ufdOKriSJbrEN8M/edit#gid=1472139207
@ChrisBeeti @tunetheweb @max-ostapenko
SQL and MD folders the 2024 Web Almanac (#3666)
2d4bceb 
* upload 2024

* change mds

* Test update

* Revert test update

* Fix line endings

---------

Co-authored-by: Barry Pollard <[email protected]>
@dependabot @max-ostapenko
Bump prettier from 3.2.5 to 3.3.0 in /src (#3672)
2c87cf2 
Bumps [prettier](https://github.com/prettier/prettier) from 3.2.5 to 3.3.0.
- [Release notes](https://github.com/prettier/prettier/releases)
- [Changelog](https://github.com/prettier/prettier/blob/main/CHANGELOG.md)
- [Commits](prettier/prettier@3.2.5...3.3.0)

---
updated-dependencies:
- dependency-name: prettier
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @max-ostapenko
Bump pytest from 8.2.1 to 8.2.2 in /src (#3673)
d60de8c 
Bumps [pytest](https://github.com/pytest-dev/pytest) from 8.2.1 to 8.2.2.
- [Release notes](https://github.com/pytest-dev/pytest/releases)
- [Changelog](https://github.com/pytest-dev/pytest/blob/main/CHANGELOG.rst)
- [Commits](pytest-dev/pytest@8.2.1...8.2.2)

---
updated-dependencies:
- dependency-name: pytest
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @max-ostapenko
Bump prettier from 3.3.0 to 3.3.1 in /src (#3674)
4f925b8 
Bumps [prettier](https://github.com/prettier/prettier) from 3.3.0 to 3.3.1.
- [Release notes](https://github.com/prettier/prettier/releases)
- [Changelog](https://github.com/prettier/prettier/blob/main/CHANGELOG.md)
- [Commits](prettier/prettier@3.3.0...3.3.1)

---
updated-dependencies:
- dependency-name: prettier
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@tunetheweb @max-ostapenko
Fix loaf monitoring bug (#3675)
846c710 
* Fix LoAF monitoring bug

* Add semi colon
@github-actions @tunetheweb @max-ostapenko
Update Timestamps (#3677)
524c51c 
Co-authored-by: tunetheweb <[email protected]>
@dependabot @max-ostapenko
Bump web-vitals from 4.0.1 to 4.1.0 in /src (#3678)
6f441ff 
Bumps [web-vitals](https://github.com/GoogleChrome/web-vitals) from 4.0.1 to 4.1.0.
- [Changelog](https://github.com/GoogleChrome/web-vitals/blob/main/CHANGELOG.md)
- [Commits](GoogleChrome/web-vitals@v4.0.1...v4.1.0)

---
updated-dependencies:
- dependency-name: web-vitals
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@max-ostapenko
fixed link
689d2ef
@max-ostapenko
remove unreviewed sql
dd21cf0
@max-ostapenko
Merge branch 'main' into privacy-sql-2024
be50c36
@max-ostapenko
lint test
320ebbe
@max-ostapenko
lint
21f612e
@max-ostapenko
ads supply graph
d0c2c35
@max-ostapenko
Copy link
Contributor Author

@tunetheweb is website redirection test failing an issue in the CI?

@tunetheweb
Copy link
Member

Looks like it's your Privacy chapter that has the issue:
image

And that looks like because it can't generate the chapter:

 Generating chapter: en, 2024, privacy
TypeError: Cannot read properties of undefined (reading 'replace')
    at convertSimpleMarkdown (/Users/barrypollard/sources/almanac.httparchive.org/src/tools/generate/shared.js:27:28)
    at generate_chapter_featured_quote (/Users/barrypollard/sources/almanac.httparchive.org/src/tools/generate/generate_featured_chapters.js:7:26)
    at generate_chapters (/Users/barrypollard/sources/almanac.httparchive.org/src/tools/generate/generate_chapters.js:100:40)
    at async /Users/barrypollard/sources/almanac.httparchive.org/src/tools/generate/index.js:6:5
  Failed to generate chapter, moving onto the next one.

And when a chapter doesn't exist it redirects to the home page.

@tunetheweb
Copy link
Member

Oh it's the featured chapter bit that's failing. this fixes it:

featured_quote: TODO
featured_stat_1: TODO
featured_stat_label_1: TODO
featured_stat_2: TODO
featured_stat_label_2: TODO
featured_stat_3: TODO
featured_stat_label_3: TODO

max-ostapenko and others added 25 commits November 4, 2024 11:10
@max-ostapenko
missing featured frontmatter
65e3538
@max-ostapenko
bring back contributors
d8cd61c
@tunetheweb
Merge branch 'main' into privacy-markdown-2024
ea0027f
@tunetheweb
Merge branch 'main' into privacy-markdown-2024
2b689f8
@max-ostapenko
Merge branch 'privacy-markdown-2024' of https://github.com/HTTPArchiv…
0d7abf3 
…e/almanac.httparchive.org into privacy-markdown-2024
@tunetheweb
Merge branch 'main' into privacy-markdown-2024
fbb8e03
@tunetheweb
Merge branch 'main' into privacy-markdown-2024
15b7d7b
@max-ostapenko
Merge branch 'privacy-markdown-2024' of https://github.com/HTTPArchiv…
8528276 
…e/almanac.httparchive.org into privacy-markdown-2024
@max-ostapenko
unique policies
3fe0e99
@max-ostapenko
extended analysis
c1f6f91
@max-ostapenko
optional charts height adjustment
3188fb9
@max-ostapenko
lint
745a134
@max-ostapenko
granular hostname match
087cdcf
@max-ostapenko
categories
b7228f3
@max-ostapenko
extended cname list
df136ea
@max-ostapenko
optimised with json column
cc3266e
@tunetheweb
Merge branch 'main' into privacy-markdown-2024
06a1b68
@tunetheweb
Merge branch 'privacy-markdown-2024' of github.com:HTTPArchive/almana…
e6b7d89 
…c.httparchive.org into privacy-markdown-2024
@max-ostapenko
bounce percentages
0ed28cd
@max-ostapenko
remove cookie header check
3f8d55b
@max-ostapenko
lint
a108d9d
@max-ostapenko
Merge remote-tracking branch 'origin/main' into privacy-markdown-2024
fde0b93
@max-ostapenko
full draft
6cdceb7
@max-ostapenko
update contributors
588e7f9
@max-ostapenko
staging url with article name
a5554aa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
writing Related to wording and content
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Privacy 2024
9 participants
@max-ostapenko @tunetheweb @ksakae1216 @rviscomi @borisschapira @ChrisBeeti @Yash-Vekaria @bstandaert-wustl @hadiamjad