[WIP] Run multiple Django and Python version's tests on Travis-CI #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Surgo
commented
Jan 17, 2019
| @@ -639,10 +639,10 @@ def get_key(self, *args, **kwargs): | |||
| value = field_dict[field.attname] | |||
| if isinstance(value, models.Model): | |||
| # get the pk value on instance | |||
| if field.rel: | |||
| rel_model = field.rel.to | |||
| if field.remote_field: | |||
There was a problem hiding this comment.
Field.rel and Field.remote_field.to are removed on Django 2.0
Surgo
commented
Jan 17, 2019
| @@ -975,7 +975,7 @@ class RelatedModelInvalidationCache(object): | |||
| """ Mixin class used in RelatedInstanceCache, RelatedQuerysetCache | |||
| """ | |||
| def _get_invalidation_models(self): | |||
| return [self.model] + self.rel_models.keys() | |||
| return [self.model] + list(self.rel_models) | |||
There was a problem hiding this comment.
Surgo
commented
Jan 17, 2019
| @@ -9,12 +9,12 @@ class ModelA(models.Model): | |||
| class ModelB(models.Model): | |||
There was a problem hiding this comment.
flash.tests module does not required in flashpackage.
So its removed from package.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO
__abstractmethods__?)