Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option for Treasure Chest Game key shuffle #133

Open
wants to merge 2 commits into
base: ootr
Choose a base branch
from

Conversation

coavins
Copy link

@coavins coavins commented Dec 2, 2023

This PR adds an option to support the shuffle of the treasure chest game keys. It is found under the TH keys shuffle option. The setting is off by default, and it's off in every preset.

  • I added a call to update_items() in init.lua so that it would account for the default setting being "off" and max out my key count by default. No idea what other consequences this has, but it makes this setting work as expected.
  • The image files I provided are just placeholders and should be replaced
  • Presets should be reviewed for correct default setting
  • I did not make the game rooms hintable, this should be verified
  • I guessed at how many rooms (and keys) are actually in the treasure chest game, please verify
  • I added the key count on a new row in the layout, you may want to put this somewhere else

image
image
image

@coavins
Copy link
Author

coavins commented Dec 2, 2023

Moved it to match the position in the OOTR generator and readme:
image
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant