Add option for Shuffle Individual Ocarina Notes #134
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an option to support the shuffle of individual ocarina notes. It is found under the shuffle frogs option.
This PR adds the logic helper
has_song
. I replaced all instances ofocarina,lullaby
with$has_song|lullaby
, and all instances ofhas("ocarina") and has("lullaby")
withhas_song("lullaby")
.TODO:
Should be verified:
logic_helpers.lua
has suspicious use ofand
andor
- I replaced this with a singlehas_song
which may affect the logic here. I don't know Lua well enough to confirmSFM Storms Grotto
andDeku Tree MQ GS Basement Graves Room
mean they now require the ocarina