Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NTSC Support (N64) #4198

Open
wants to merge 59 commits into
base: develop
Choose a base branch
from
Open

Conversation

inspectredc
Copy link
Contributor

@inspectredc inspectredc commented May 31, 2024

Supports all N64 NTSC Versions

A few small todos that dont need to be addressed in this PR, mostly being translations or tts related.

Build Artifacts

@inspectredc
Copy link
Contributor Author

inspectredc commented May 31, 2024

@stellarkookies
Copy link

stellarkookies commented Jul 26, 2024

@inspectredc hello! i've been trying to build your NTSC branch for testing and such, but i don't seem to be having much luck. I get the following build error in ArrayExporter.cpp (from your OTRExporter NTSC branch):

/var/home/kookies/git/src/Shipwright/OTRExporter/OTRExporter/ArrayExporter.cpp: In member function ‘virtual void OTRExporter_Array::Save(ZResource*, const std::filesystem::__cxx11::path&, BinaryWriter*)’:
/var/home/kookies/git/src/Shipwright/OTRExporter/OTRExporter/ArrayExporter.cpp:8:84: error: ‘SOH_Array’ is not a member of ‘SOH::ResourceType’
    8 |         WriteHeader(res, outPath, writer, static_cast<uint32_t>(SOH::ResourceType::SOH_Array));
      |                                                                                    ^~~~~~~~~

Would this be something on my end? Or perhaps some desync with upstream? Thanks in advance for any help you might have. Also thanks for the porting work; much appreciated from an owner of a US copy :P

@Malkierian
Copy link
Contributor

I'm not exactly sure what that error is about, might be build tools issues, but you don't need to build it yourself to test it, there are downloads available in the original comment.

@MST246
Copy link

MST246 commented Aug 21, 2024

Hi
All seems to be working well (Win 11) except bombs. When trying to assign them to C, the game crashes. Sometimes just highlighting them in the inventory will also crash the game. Can provide log file if needed. Using Oot version 1.0 USA

@MST246
Copy link

MST246 commented Sep 6, 2024

Apologies if this is the wrong place for NTSC version to be discussed, but I don't see anywhere else to do so. It seems as if the "bomb crash" issue was fixed if, I understand the Dev lingo, But the bomb bag sometimes shows up in the deku stick slot. I can even set it to -c. I can fix this quickly in the save editor.

Under Camara Controls >Invert shield aim axis x/y. Ticking either one marks both boxes.

The NTSC version seems to include some enhancements/cheats that the Pal version does not, such as, the frog/lost woods mini games. Just wondering why this is the case and is the only reason I use the NTSC version.

The Pal version has a controller setting I love called "Deadzones for sticks as buttons" that can completely eliminate hitting a wrong input on the right (-c) stick. Hoping this is implemented into the NTSC version otherwise can continue to use a third party app to do the same.

@inspectredc
Copy link
Contributor Author

This is based on the base ship version so it is not a NTSC only version but an NTSC and PAL version. As such all enhancements on that should exist on this, however, since this is based on a develop version of SoH you may find that it has more recent features compared to the latest release.

As for the bomb bag thing, are you sure you didnt not open the bomb bag chest while already having bomb bag in your inventory? This is a glitch that occurs on all the soh versions and is similar to the bomb bag appearing over the bombchu slot as it does on console under the same circumstances

@MST246
Copy link

MST246 commented Sep 6, 2024

This is based on the base ship version so it is not a NTSC only version but an NTSC and PAL version. As such all enhancements on that should exist on this, however, since this is based on a develop version of SoH you may find that it has more recent features compared to the latest release.

As for the bomb bag thing, are you sure you didnt not open the bomb bag chest while already having bomb bag in your inventory? This is a glitch that occurs on all the soh versions and is similar to the bomb bag appearing over the bombchu slot as it does on console under the same circumstances

I'm pretty sure I just gave myself the bag then added the bombs into to the inventory through the save editor. Also pretty sure I intentionally stayed away from the chest as that had occurred to me. I can fire another game, but may have to play awhile because this last time it happened after/during the deku sprout scene.

Tested it out just now. Gave myself bag/bombs went up and opened the chest and it happened.

@sitton76 sitton76 mentioned this pull request Nov 4, 2024
@yyoossk
Copy link

yyoossk commented Nov 4, 2024

Can someone build it for me?
soh.nro
soh.wuhb
https://github.com/inspectredc/Shipwright.git

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants