Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Localization #2637

Open
wants to merge 13 commits into
base: dragonflight
Choose a base branch
from
Open

Conversation

stephenjang
Copy link
Contributor

@stephenjang stephenjang commented May 19, 2023

I did a completely rewrite for localization.
There are a lot of changes, but I only changed what is represented in the UI. Except for those related to data.

  • Unlike L[] in AceLocale3, the _L[] metatable does not throw an error if there is a missing entry. _L[] is used as an optional entries in the package or list and the description of the list.
  • Also, the description input of entry is changed to multiline 6 lines to check for long messages.
  • Due to word order differences in languages like Korean, entries with multiple %s in the formatted strings have been changed to numbered variables (%1$s, %2$s...). Order-independent words like 'and' or 'or' are excluded.
  • Modified built-in packs or lists to be displayed in Blizzard blue color.
  • Added more power types (blood_runes, frost_runes, unholy_runes, happiness for WotLK).
  • Moved the version check functions to namespace for use in locales. However, those functions have been reassigned in Hekili.lua for backwards compatibility.
  • Modified SaveDebugSnapshot() function so that only the snapshots dropdown selector shows localization.
  • Added a description to the tooltip in the MultilineEditor.lua file.
  • Moved hideOmniCC to the Delays tab. I think that's probably a better place for it.
  • Default values are shown as values for displayTemplate, if available, and the default value for frameStrata has been modified from "LOW" to "MEDIUM".
  • Modified to get default values from displayTemplate if available. Also fixed the default value for frameStrata from "LOW" to "MEDIUM".
  • Added GetPlainText() function for Import Log: Workaround for EditBox not supporting escape sequence for preposition or postposition.
  • Added button disabled to avoid an error when the Import button is pressed on an empty profile and no profile exists.
  • Show Heroism instead of Bloodlust if the player's faction is Alliance.
  • The shadowmeld option is only available for Night Elf, otherwise it is disabled.
  • Changed the package name of Demon Hunter from Havoc to Havoc DH. Because it's the same as Warlock.
  • Removed word wrap escapes from messages and added the ns.WordWrapper() function.
  • Added the ns.WARNING prefix to the namespace.
  • I'm also working on a WotLK version. I'll PR it when it's ready.

Do you have any better ideas or thoughts?

@stephenjang
Copy link
Contributor Author

stephenjang commented May 20, 2023

Updated locales and fixed a bug that was causing a error in the actions list tab.
For now, I've removed the wrath messages. Unless you have plans to merge with the wrath branch in the future.

@daoye
Copy link

daoye commented Oct 14, 2023

Hi @Hekili , do you have any further questions about this PR? I think I have time to submit a Chinese translation, but it might need to wait until @stephenjang 's work is merged into the main branch.

@Hekili
Copy link
Owner

Hekili commented Nov 14, 2023

If this is brought up to date, I will accept the PR. Thanks for the hard work.

@huchang47
Copy link

I have been maintaining the Simplified Chinese version through global translation replacement for a long time, And shared in the largest Chinese wower forum. After the localization transformation is completed, I can immediately switch to the production of local language files. Looking forward to the 11.0 version being equipped with a complete localization.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants