extendBuff( aura, duration ) function for cleaner code

[syrifgit]

Instead of writing buff.metamorphosis.expires = buff.metamorphosis.expires + 8

You'd write extendBuff( "metamorphosis", 8 )

Works with negative numbers, a check for the buff being removed if negative extension is greater than remaining duration, breaks out on 0.

Thoughts? What else am I missing to polish this up if you're interested in having it?

I copied it from addstack, unsure if I actually need the local a = class.auras[ aura ]?

[syrifgit]

Review notes implemented, thanks @johnnylam88

108 ish references (some might not be duration changes) where this function could be used

[Hekili]

I'm open to something like this, though the name might be different (i.e., not extend) if we're anticipating using it for extensions and reductions (modifyRemains ?). Not sure yet.

Additionally, I'm curious about whether this should accomplish any of the following:

• Shift check for aura being up into this function? That way we don't need if buff.x.up then extendBuff( "x", 2 ) end.
• Have it return true or false depending on whether the aura was successfully modified?
  • This lets us do something like if extendBuff( "shield_block", 1 ) then do something end (successful extension).
  • Or if extendBuff( "ritual_overlord", -1 ) then do something end (reduction that wipes the aura?).
• Consider whether we want separate functions for buffs/debuffs or whether it would make more sense to do something like extendAura( buff.battle_shout, 5 ) so we just pass the aura (table) we care about?

[syrifgit]

Additionally, I'm curious about whether this should accomplish any of the following:

• Shift check for aura being up into this function? That way we don't need if buff.x.up then extendBuff( "x", 2 ) end.

Sounds smart to me, cleaner code in the class files. Should we do the same for stuff like removeBuff(), removeStack()? removeStack() may already have this, but we could do a sanity check on all related functions.

• Have it return true or false depending on whether the aura was successfully modified?
  • This lets us do something like if extendBuff( "shield_block", 1 ) then do something end (successful extension).
  • Or if extendBuff( "ritual_overlord", -1 ) then do something end (reduction that wipes the aura?).

Agree, but to clarify, "asking" if extendBuff(), it will actually apply the modification every time? It's not a "is this possible", it's a "do it, and I care if it worked or not for reasons other than the duration of the aura"

• Consider whether we want separate functions for buffs/debuffs or whether it would make more sense to do something like extendAura( buff.battle_shout, 5 ) so we just pass the aura (table) we care about?

Either way would make sense to me, I was going to ask about debuffs after completing this one.

Will do some revising today.

[syrifgit]

Did a pass over the function @Hekili @johnnylam88.

auraDuration( unit, aura, duration )

• how do I make sure unit is optional? Is that possible?
• Am I missing any checks?
• Should a "successful" execution return true or false if the aura is removed due to the execution? Or does it simply indicate success if it worked?
• Name can be whatever