Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add power siphon and felstorm conditions to demonology simc #4242

Open
wants to merge 1 commit into
base: thewarwithin
Choose a base branch
from

Conversation

joshjau
Copy link
Contributor

@joshjau joshjau commented Dec 9, 2024

ported from simc source (sc_warlock_pets.cpp, sc_warlock_actions.cpp):

power siphon:

  • prevent core capping before tyrant window
  • checks for < 3 demonic cores
  • tyrant cd > 25s
  • not during demonic power buff

felstorm:

  • add cleave logic for fel sunder builds
  • requires 2+ targets
  • checks demonic strength talent/cd
  • requires fel sunder talent

also cleaned up some tyrant timing logic and imp despawn variable tracking

ported from simc source (sc_warlock_pets.cpp, sc_warlock_actions.cpp):

power siphon:
- prevent core capping before tyrant window
- checks for < 3 demonic cores
- tyrant cd > 25s
- not during demonic power buff

felstorm:
- add cleave logic for fel sunder builds
- requires 2+ targets
- checks demonic strength talent/cd
- requires fel sunder talent

also cleaned up some tyrant timing logic and imp despawn variable tracking
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant