Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coqide: rename to coq-platform, update #191558

Merged
merged 2 commits into from
Nov 23, 2024
Merged

Conversation

krehel
Copy link
Member

@krehel krehel commented Nov 11, 2024

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:


  • Renames the cask from coqide to coq-platform

  • Adds the latest version for both ARM and Intel

  • Update URL and livecheck

This update renames the cask and provides many updates. I noticed that coqide had not received an update for many years, and the current repository location was only doing source releases.

There is another repository under the coq organization that is doing binary releases under coq-platform that contains the same IDE with a new name. Therefore a rename has been performed and all Cask aspects updated to account for this.

Currently ARM and Intel versions are out of sync, which requires the on_#{arch} blocks to account for versions.

I'm not an expert on the Coq ecosystem, but this seems like it is equivalent in what is provided.

@krehel
Copy link
Member Author

krehel commented Nov 11, 2024

Currently this is failing the signature verification check, but since this is technically an existing Cask we should override.

@khipp
Copy link
Member

khipp commented Nov 11, 2024

I'm fine with overriding the audit for the reasons stated above.

However, I think we should invert the version components to put the IDE version first.

@krehel
Copy link
Member Author

krehel commented Nov 11, 2024

Possibly. I put it this way because version.csv.first is the platform release version, version.csv.second is the Coq language version included in the platform. This seemed like a natural order.

Overall both should be incrementing version numbers so I don't think it'll break either way.

* Renames the cask from `coqide` to `coq-platform`

* Adds the latest version for both ARM and Intel

* Update URL and livecheck
@khipp
Copy link
Member

khipp commented Nov 14, 2024

From the release notes for version 2024.10.0:

The MacOS installer is now not only signed, but also notarized.
Note: the MacOS intel installer is work in progress

This should pass the audit once the Intel version has been bumped as well.

On a side note, since the ARM version is signed, do we expect the signing audit to also run for the Intel version?

@krehel
Copy link
Member Author

krehel commented Nov 23, 2024

Hi @Homebrew/cask is there something else I should do here? I think this is good to go. This replaces an outdated version and the version updates are not consistent so I don't think we should wait on an Intel version.

@p-linnane p-linnane added the ci-syntax-only Only run syntax checks on CI. Use only for bulk changes. label Nov 23, 2024
@p-linnane p-linnane merged commit adce22d into master Nov 23, 2024
15 checks passed
@p-linnane p-linnane deleted the coqide-rename-and-updates branch November 23, 2024 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge-skip ci-syntax-only Only run syntax checks on CI. Use only for bulk changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants