-
-
Notifications
You must be signed in to change notification settings - Fork 10.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
coqide: rename to coq-platform
, update
#191558
Conversation
026f56c
to
e8cfce8
Compare
Currently this is failing the signature verification check, but since this is technically an existing Cask we should override. |
I'm fine with overriding the audit for the reasons stated above. However, I think we should invert the version components to put the IDE version first. |
Possibly. I put it this way because Overall both should be incrementing version numbers so I don't think it'll break either way. |
* Renames the cask from `coqide` to `coq-platform` * Adds the latest version for both ARM and Intel * Update URL and livecheck
e8cfce8
to
bd2bd5d
Compare
From the release notes for version 2024.10.0:
This should pass the audit once the Intel version has been bumped as well. On a side note, since the ARM version is signed, do we expect the signing audit to also run for the Intel version? |
Hi @Homebrew/cask is there something else I should do here? I think this is good to go. This replaces an outdated version and the version updates are not consistent so I don't think we should wait on an Intel version. |
Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.
In the following questions
<cask>
is the token of the cask you're submitting.After making any changes to a cask, existing or new, verify:
brew audit --cask --online <cask>
is error-free.brew style --fix <cask>
reports no offenses.Renames the cask from
coqide
tocoq-platform
Adds the latest version for both ARM and Intel
Update URL and livecheck
This update renames the cask and provides many updates. I noticed that
coqide
had not received an update for many years, and the current repository location was only doing source releases.There is another repository under the
coq
organization that is doing binary releases undercoq-platform
that contains the same IDE with a new name. Therefore a rename has been performed and all Cask aspects updated to account for this.Currently ARM and Intel versions are out of sync, which requires the
on_#{arch}
blocks to account for versions.I'm not an expert on the Coq ecosystem, but this seems like it is equivalent in what is provided.