Skip to content
This repository has been archived by the owner on Jul 4, 2023. It is now read-only.

khard 0.8.1 #49907

Closed
wants to merge 1 commit into from
Closed

khard 0.8.1 #49907

wants to merge 1 commit into from

Conversation

ilovezfs
Copy link
Contributor

@ilovezfs ilovezfs commented Mar 9, 2016

Other than that it's outdated, the reason for PR is

curl: (22) The requested URL returned error: 404 Not Found
Error: Failed to download resource "khard--vobject"
Download failed: https://pypi.python.org/packages/source/v/vobject/vobject-0.8.1c.tar.gz

@DomT4
Copy link
Member

DomT4 commented Mar 9, 2016

desc is always the first line of the initial block 😉.

Merged in 1aa9b4b. Thanks again @ilovezfs!

@DomT4 DomT4 closed this in 1aa9b4b Mar 9, 2016
@ilovezfs
Copy link
Contributor Author

ilovezfs commented Mar 9, 2016

@DomT4 Ah, thanks for fixing that. I was hand patching the desc back in after using @tdsmith's excellent poet thingy https://github.com/tdsmith/homebrew-pypi-poet

@DomT4
Copy link
Member

DomT4 commented Mar 9, 2016

No worries at all! It's nice my over-zealous checking of PR diffs prior to merging comes in handy every now and again, heh.

@ilovezfs
Copy link
Contributor Author

ilovezfs commented Mar 9, 2016

@DomT4 :) Also, I think it would be cool if poet could grab the test block and the desc from the preexisting formula, which I just suggested to Tim on IRC.

@DomT4
Copy link
Member

DomT4 commented Mar 9, 2016

Are you using it to write the whole formulae or just the resource blocks?

@ilovezfs
Copy link
Contributor Author

ilovezfs commented Mar 9, 2016

It was my first go with it, so I figured I'd let it write the whole thing and see where we landed up:
https://www.irccloud.com/pastebin/MNmGa1pr/

@DomT4
Copy link
Member

DomT4 commented Mar 9, 2016

Ah, interesting. That'd explain why people haven't noticed (or at least reported) it to date; I think generally people use it for the resource blocks and that's it. You're right that it shouldn't be stamping on desc lines.

@ilovezfs
Copy link
Contributor Author

ilovezfs commented Mar 9, 2016

xu-cheng pushed a commit to Homebrew/homebrew-core that referenced this pull request Mar 10, 2016
Closes Homebrew/legacy-homebrew#49907.

Signed-off-by: Dominyk Tiller <[email protected]>
@ilovezfs ilovezfs deleted the khard-0.8.1 branch March 14, 2016 13:25
@Homebrew Homebrew locked and limited conversation to collaborators Jul 10, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants