Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CU 3/10 #22

Merged
merged 15 commits into from
Mar 14, 2024
Merged

CU 3/10 #22

merged 15 commits into from
Mar 14, 2024

Conversation

tkcy
Copy link
Contributor

@tkcy tkcy commented Mar 12, 2024

No description provided.

kjsato and others added 15 commits March 5, 2024 01:55
…validate-submission.yaml to invoke a workflow to push data after pr merged, because a PR from forked repo cannot permit using secrets
…to tkcy-main

deleted 2024-03-10-CU-RSV_SVIRS.parquet.gz
@kjsato
Copy link
Collaborator

kjsato commented Mar 13, 2024

@tkcy Could you check the file https://github.com/tkcy/rsv-forecast-hub/blob/main/model-output/CU-RSV_SVIRS/2024-03-10-CU-RSV_SVIRS.parquet which I converted the origin_date column if it is okay?
If that's file, I'll go ahead with it

@kjsato
Copy link
Collaborator

kjsato commented Mar 14, 2024

@tkcy I will proceed with it though I did not get an answer, because it seemed no problem would be seen

@kjsato kjsato merged commit 98512df into HopkinsIDD:main Mar 14, 2024
1 check passed
@tkcy
Copy link
Contributor Author

tkcy commented Mar 14, 2024 via email

@kjsato
Copy link
Collaborator

kjsato commented Mar 14, 2024

No problem, the result can be found:
https://hopkinsidd.github.io/rsv-forecast-hub_website/

@tkcy
Copy link
Contributor Author

tkcy commented Mar 14, 2024

Thanks, the visualization is helpful! I see I've been misunderstanding the numbering for horizon week, I have been starting at horizon 1 for the first week of projection instead of 0. I'll correct this going forward.

@kjsato
Copy link
Collaborator

kjsato commented Mar 14, 2024

Okay, please issue a new pr after your modification is done.

kjsato added a commit that referenced this pull request Mar 26, 2024
modified and deleted the path test code part in ensemble.R
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants