Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PSI-PROF weekly submission - 24 Mar 2024 #33

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

jturtle
Copy link
Contributor

@jturtle jturtle commented Mar 25, 2024

No description provided.

@kjsato
Copy link
Collaborator

kjsato commented Mar 25, 2024

Thanks for your submissions. I'd like to notify that your model-output file (including the former submissions) data is 1w behind our expected origin_date, and the output is not reflected on website(2024-03-24 for this week). We would appreciate it if you could reflect that in the data one week ahead,

Thank you,

@kjsato
Copy link
Collaborator

kjsato commented Mar 26, 2024

approved to merge

@kjsato kjsato merged commit 2e45b10 into HopkinsIDD:main Mar 26, 2024
1 check passed
@jturtle
Copy link
Contributor Author

jturtle commented Mar 29, 2024 via email

@kjsato
Copy link
Collaborator

kjsato commented Mar 29, 2024

@jturtle sorry for my late response and the inconvienence. Yes, in this week's submission (2024-3-24), we would have expected to have data with origin_date 2024-03-24 of which filename would be 2024-03-24-PSI-PROF.parquet, and it contains the week from 03-24 with horizon=0 in your case.

In this case, at the time of data processing, filename was a date in the past (if origin_date was a date in the past, the file name would be the same of course), so it was excluded from processing.
At least filename and data cannot go back in time, so I would appreciate it if you could set filename (e.g, 2024-03-24-PSI-PROF.parquet) and the data to match this week's (with origin_date "2024-03-24").

Thank you,

@jturtle
Copy link
Contributor Author

jturtle commented Mar 29, 2024 via email

kjsato added a commit that referenced this pull request Jun 5, 2024
modified to add install dependencies with the custom hubUtils and hub…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants