fix: Update port manager shutdown flow #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joe-yeager
requested review from
brandenrodgers,
camden11 and
kemmerle
as code owners
joe-yeager
commented
Nov 14, 2024
Comment on lines
+15
to
+20
| export async function isPortManagerPortAvailable(): Promise<boolean> { | ||
| return ( | ||
| (await detectPort(PORT_MANAGER_SERVER_PORT)) === PORT_MANAGER_SERVER_PORT | ||
| ); | ||
| } | ||
|
|
There was a problem hiding this comment.
This is primarily for use with the hs doctor command since it is currently using isPortManagerServerRunning to check if the port is available and the logic of that is changing
joe-yeager
changed the title
camden11
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description and Context
Updates the portManager shutdown flow to call a health check endpoint before attempting to shutdown the server.
TODO
hs doctorPR was making use of theisPortManagerServerRunningand will need to be updated to use theisPortManagerPortAvailable