Chore: update project types #221
Merged
+34
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camden11
requested review from
brandenrodgers,
kemmerle and
joe-yeager
as code owners
brandenrodgers
approved these changes
Dec 17, 2024
|
Good question. I wasn't really thinking of it as a breaking change since it only changes types and not functionality. But it does break types. I'll look into what other people are doing for things like this |
|
I think I would argue that it even though it's technically breaking, it's actually a bug fix because the functionality that it's breaking didn't really work before (if you tried to use those types as they were defined, you'd run into issues). Maybe a good middle ground is to continue to export |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description and Context
This fixes a few inaccuracies with types related to projects + removes the
OptionalErrortypes which is no longer needed.Type changes based on API responses herer: https://tools.hubteam.com/api-catalog/services/DFSBuildPipelineService/v1/spec/internal
Who to Notify
@brandenrodgers @joe-yeager @kemmerle