fix: corrige erreurs remontées par phpmd

IGNF · Nov 23, 2023 · cf984cd · cf984cd
1 parent cf9654d
commit cf984cd
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/phpmd.xml b/phpmd.xml
@@ -15,6 +15,7 @@
         <exclude name="ElseExpression" />
         <exclude name="StaticAccess" />
         <exclude name="MissingImport" />
+        <exclude name="BooleanArgumentFlag" />
     </rule>
     <!--
     <rule ref="rulesets/codesize.xml" />

diff --git a/src/Listener/CartesApiExceptionSubscriber.php b/src/Listener/CartesApiExceptionSubscriber.php
@@ -41,17 +41,18 @@ public function onCartesApiException(ExceptionEvent $event): void
 
     private function getErrorResponse(CartesApiException $throwable): JsonResponse
     {
+        $statusText = 'Internal Server Error';
         $responseData = [
             'code' => Response::HTTP_INTERNAL_SERVER_ERROR,
-            'status' => Response::$statusTexts[Response::HTTP_INTERNAL_SERVER_ERROR],
+            'status' => $statusText,
             'message' => 'An internal error has occurred',
             'details' => [],
         ];
 
         if ($throwable instanceof CartesApiException) {
             $code = $throwable->getCode();
             $responseData['code'] = $code;
-            $responseData['status'] = Response::$statusTexts[$code];
+            $responseData['status'] = $statusText;
             $responseData['message'] = $throwable->getMessage();
             $responseData['details'] = $throwable->getDetails();
         }

diff --git a/src/Listener/InternalApiSubscriber.php b/src/Listener/InternalApiSubscriber.php
@@ -55,7 +55,7 @@ public function onKernelController(ControllerEvent $event): void
                 // TODO préciser que c'est l'API interne
                 if (null == $accessToken
                     || (null != $accessToken && $accessToken->hasExpired())) {
-                    throw new CartesApiException(Response::$statusTexts[Response::HTTP_UNAUTHORIZED], Response::HTTP_UNAUTHORIZED, ['controller' => ApiControllerInterface::class]);
+                    throw new CartesApiException('Unauthorized', Response::HTTP_UNAUTHORIZED, ['controller' => ApiControllerInterface::class]);
                 }
             }
         }