Method Element::matches() allows check children nodes

Imangazaliev · May 14, 2017 · 69ab6a0 · 69ab6a0
1 parent c37358f
commit 69ab6a0
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 1 deletion.
diff --git a/src/DiDom/Element.php b/src/DiDom/Element.php
@@ -263,7 +263,7 @@ public function matches($selector, $strict = false)
                 throw new LogicException('Node must be an instance of DOMElement');
             }
 
-            $innerHtml = $node->ownerDocument->saveXml($node, LIBXML_NOEMPTYTAG);
+            $innerHtml = $this->html();
             $html = "<root>$innerHtml</root>";
 
             $selector = 'root > '.trim($selector);

diff --git a/tests/DiDom/ElementTest.php b/tests/DiDom/ElementTest.php
@@ -340,6 +340,25 @@ public function testMatches()
         $element = new Element('p');
 
         $this->assertTrue($element->matches('p', true));
+
+        $html = '<!DOCTYPE html>
+        <html lang="en">
+        <head>
+            <meta charset="UTF-8">
+            <title>Document</title>
+        </head>
+        <body>
+            <a href="#"><img src="foo.jpg" alt="Foo"></a>
+        </body>
+        </html>';
+
+        $document = new Document($html, false);
+        $anchor = $document->first('a');
+
+        $this->assertTrue($anchor->matches('a:has(img[src$=".jpg"])'));
+        $this->assertTrue($anchor->matches('a img'));
+        $this->assertFalse($anchor->matches('a img[alt="Bar"]'));
+        $this->assertFalse($anchor->matches('img'));
     }
 
     public function testHasAttribute()