Fix parsing of a style property in "style" attribute when the value c…

…ontains a colon
Imangazaliev · Feb 9, 2021 · 7fc9cc1 · 7fc9cc1
1 parent e5bcdd3
commit 7fc9cc1
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/DiDom/StyleAttribute.php b/src/DiDom/StyleAttribute.php
@@ -73,7 +73,7 @@ protected function parseStyleAttribute()
         $properties = explode(';', $styleString);
 
         foreach ($properties as $property) {
-            list($name, $value) = explode(':', $property);
+            list($name, $value) = explode(':', $property, 2);
 
             $name = trim($name);
             $value = trim($value);

diff --git a/tests/StyleAttributeTest.php b/tests/StyleAttributeTest.php
@@ -171,9 +171,9 @@ public function getPropertyDataProvider()
                 '16px',
             ],
             [
-                'color: blue; font-size: 16px; border: 1px solid black;',
-                'font-size',
-                '16px',
+                'background-image: url(https://example.com/image.jpg); background-repeat: no-repeat',
+                'background-image',
+                'url(https://example.com/image.jpg)',
             ],
             [
                 'color: blue; font-size: 16px; border: 1px solid black;',