Fix bug in setInnerHtml: can't rewrite existing content

Imangazaliev · May 15, 2017 · a00fe02 · a00fe02
1 parent dc05790
commit a00fe02
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 2 deletions.
diff --git a/src/DiDom/Element.php b/src/DiDom/Element.php
@@ -464,9 +464,19 @@ public function setInnerHtml($html)
         }
 
         // remove all child nodes
-        foreach ($this->node->childNodes as $node)
+
+        // we need to collect child nodes to array
+        // because removing nodes from the DOMNodeList on iterating is not working
+        $childNodes = [];
+
+        foreach ($this->node->childNodes as $childNode)
+        {
+            $childNodes[] = $childNode;
+        }
+
+        foreach ($childNodes as $childNode)
         {
-            $this->node->removeChild($node);
+            $this->node->removeChild($childNode);
         }
 
         if ($html !== '') {

diff --git a/tests/DiDom/ElementTest.php b/tests/DiDom/ElementTest.php
@@ -510,6 +510,13 @@ public function testSetInnerHtml()
         $this->assertEquals($list, $list->setInnerHtml($html));
         $this->assertEquals(['One', 'Two', 'Three'], $list->find('li::text'));
 
+        // check inner HTML rewrite works
+
+        $html = '<li>Foo</li><li>Bar</li><li>Baz</li>';
+
+        $this->assertEquals($list, $list->setInnerHtml($html));
+        $this->assertEquals(['Foo', 'Bar', 'Baz'], $list->find('li::text'));
+
         $html = '<div id="root"></div>';
         $innerHtml = ' Plain text <span>Lorem ipsum.</span><span>Lorem ipsum.</span>';