Allows for the selectbox to display selected values with index '0' #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this change the selectbox wasn't able to display selected values (reference-mode:id) with index '0' (as number, not string). An example would be enum properties which are bound to the selectbox by id. Although it's possible to select an enum value with id '0' and save it (assuming we can save the selected value to a database), reloading it from aforementioned database prevents it from beeing displayed in the selectbox, 'undefined' (or nothing) is displayed instead. This change allows for the selectbox to display enum values with index '0' (or values with index '0' in general).
Codecov Report
@@ Coverage Diff @@
## master #54 +/- ##
=======================================
Coverage 90.87% 90.87%
=======================================
Files 6 6
Lines 241 241
Branches 46 46
=======================================
Hits 219 219
Misses 7 7
Partials 15 15
Continue to review full report at Codecov.
|
TyPleks
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change the selectbox wasn't able to display selected values (reference-mode:id) with index '0' (as number, not string). An example would be enum properties which are bound to the selectbox by id. Although it's possible to select an enum value with id '0' and save it (assuming we can save the selected value to a database), reloading it from aforementioned database prevents it from beeing displayed in the selectbox, 'undefined' (or nothing) is displayed instead. This change allows for the selectbox to display enum values with index '0' (or values with index '0' in general).