-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Christopherngutierrez/test context parse results #37
Merged
faberga
merged 6 commits into
main
from
christopherngutierrez/test-context-parse-results
Aug 20, 2024
Merged
Christopherngutierrez/test context parse results #37
faberga
merged 6 commits into
main
from
christopherngutierrez/test-context-parse-results
Aug 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntain multiple Context or no Context. Doing so will raise a LookupError with a description of the problem. Two test cases are also included in tests/test_kerngen.py to verify that the correct error is raised.
…g ParseResults.context and removed checks in constructor
hamishun
suggested changes
Aug 6, 2024
Fixed copyright issue in test_kerngen.py. Co-authored-by: Hamish Hunt <[email protected]>
hamishun
previously approved these changes
Aug 6, 2024
Removed README.MD from pull request, per @faberga suggestion. |
christopherngutierrez
requested review from
faberga,
kylanerace,
jobottle and
jlhcrawford
as code owners
August 14, 2024 17:05
jobottle
approved these changes
Aug 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
hamishun
approved these changes
Aug 15, 2024
christopherngutierrez
added a commit
that referenced
this pull request
Oct 21, 2024
* Modified Context in ParseResults to verify that _commands does not contain multiple Context or no Context. Doing so will raise a LookupError with a description of the problem. Two test cases are also included in tests/test_kerngen.py to verify that the correct error is raised. * Renamed tests for ParseResults. Modified check to occur when accessing ParseResults.context and removed checks in constructor * Update kerngen/tests/test_kerngen.py * Fixed copyright issue in test_kerngen.py. * Removed modified README.md file from pull request --------- Co-authored-by: Hamish Hunt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Changes:
_get_context_from_commands_list
static method to verify thatParseResults._commands
contains exactly oneContext
.Context
or noContext
is found inParseResult._commands
.What types of changes does your code introduce to the HE Toolkit project?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creatingthe PR. If you are unsure about any of them, do not hesitate to ask. We are
here to help! This is simply a reminder of what we are going to look for before
merging your code.
Further comments
If this is a relatively large or complex change, kick off the discussion by
explaining why you chose the solution you did, what alternatives you
considered, etc.