Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Christopherngutierrez/test context parse results #37

Merged
merged 6 commits into from
Aug 20, 2024

Conversation

christopherngutierrez
Copy link
Contributor

@christopherngutierrez christopherngutierrez commented Aug 2, 2024

Proposed changes

Changes:

  • kerngen/high_parser/parser.py: added _get_context_from_commands_list static method to verify that ParseResults._commands contains exactly one Context.
  • kerngen/tests/test_kerngen.py: contains two additional test to verify that a "LookupError" is raised if multiple Context or no Context is found in ParseResult._commands.
  • pytest.ini: points to the source code directory. Fixes issue with imports on tests.

What types of changes does your code introduce to the HE Toolkit project?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating
the PR. If you are unsure about any of them, do not hesitate to ask. We are
here to help! This is simply a reminder of what we are going to look for before
merging your code.

  • I have read the CONTRIBUTING agreement
  • Current formatting and unit tests / base functionality passes locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by
explaining why you chose the solution you did, what alternatives you
considered, etc.

…ntain multiple Context or no Context. Doing so will raise a LookupError with a description of the problem. Two test cases are also included in tests/test_kerngen.py to verify that the correct error is raised.
…g ParseResults.context and removed checks in constructor
kerngen/tests/test_kerngen.py Outdated Show resolved Hide resolved
Fixed copyright issue in test_kerngen.py.

Co-authored-by: Hamish Hunt <[email protected]>
hamishun
hamishun previously approved these changes Aug 6, 2024
@christopherngutierrez
Copy link
Contributor Author

Removed README.MD from pull request, per @faberga suggestion.

Copy link

@jobottle jobottle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@faberga faberga added the bug Something isn't working label Aug 20, 2024
@faberga faberga merged commit 32ad854 into main Aug 20, 2024
3 checks passed
@faberga faberga deleted the christopherngutierrez/test-context-parse-results branch August 20, 2024 20:13
christopherngutierrez added a commit that referenced this pull request Oct 21, 2024
* Modified Context in ParseResults to verify that _commands does not contain multiple Context or no Context. Doing so will raise a LookupError with a description of the problem. Two test cases are also included in tests/test_kerngen.py to verify that the correct error is raised.

* Renamed tests for ParseResults. Modified check to occur when accessing ParseResults.context and removed checks in constructor
* Update kerngen/tests/test_kerngen.py
* Fixed copyright issue in test_kerngen.py.
* Removed modified README.md file from pull request

---------

Co-authored-by: Hamish Hunt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants