Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CKKS Bug Fixes for Relin/Rotate/Mod/Rescale (RNS > 3) #57

Merged
merged 2 commits into from
Nov 13, 2024

Conversation

christopherngutierrez
Copy link
Contributor

Proposed changes

  • Fixed bug in mod that produced unused instructions
  • Fixed bug in rescale that produced unused instructions
  • Added new option in Polys.from_polys to set RNS=1. Used in bug fixes.

Types of changes

What types of changes does your code introduce to the HE Toolkit project?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating
the PR. If you are unsure about any of them, do not hesitate to ask. We are
here to help! This is simply a reminder of what we are going to look for before
merging your code.

  • I have read the CONTRIBUTING agreement
  • Current formatting and unit tests / base functionality passes locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Copy link

@kylanerace kylanerace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran and LGTM. Will need to do a wider test a bit later.

@faberga faberga added the bug Something isn't working label Nov 13, 2024
@faberga faberga merged commit 9ed33df into main Nov 13, 2024
3 checks passed
@faberga faberga deleted the christopherngutierrez/ckks-mod-bug-fix branch November 13, 2024 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants