Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coloring and map_element_nodes do not play well together #61

Open
Andlon opened this issue Mar 23, 2023 · 0 comments
Open

Coloring and map_element_nodes do not play well together #61

Andlon opened this issue Mar 23, 2023 · 0 comments

Comments

@Andlon
Copy link
Member

Andlon commented Mar 23, 2023

This applies to VectorParAssembler and CsrParAssembler, both of which require coloring. Usually coloring happens at an earlier stage than when you'd use map_element_nodes, meaning that after map_element_nodes, the coloring no longer corresponds to the mapped indices.

I'm not sure how best to fix this in the short term - at the very least, the assemblers should detect this issue and return an error, which they currently don't do. Long term, we anyway want to move to parallel assembly that doesn't longer coloring, which should resolve this issue that way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant