checking exported ledger types to have Arbitrary instances #6428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aleeusgr
changed the title
This comment was marked as outdated.
This comment was marked as outdated.
The code I wrote uses |
aleeusgr
commented
Sep 9, 2024
There was a problem hiding this comment.
-- This test suite checks the correctness of the PlutusLedgerApi module.
-- It uses QuickCheck to verify that certain types have Arbitrary instances,
TODO:
- list all types that need to be checked.
aleeusgr
commented
Sep 9, 2024
| testsArb :: IO TestTree | ||
| testsArb = do | ||
| files <- listDirectory "./src/PlutusLedgerApi" | ||
| let hsFiles = filter (\file -> file `elem` ["V1.hs", "V2.hs"]) files |
There was a problem hiding this comment.
which files do we check?
aleeusgr
commented
Sep 9, 2024
|
|
||
| parseExports :: FilePath -> IO [String] | ||
| parseExports filePath = do | ||
| output <- readProcess "ghc" ["--show-iface", "./src/PlutusLedgerApi/" ++ filePath] "" |
How to read code coverage report?
|
aleeusgr
force-pushed
the
ledger-types-testing
branch
from
ed07a32 to
f912edc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue I am working on asks to implement Arbitrary instances for the types plutus-ledger-api exports so I wrote tests to check if a type has an Arbitrary instance and to check module against a list of exports verified by the user:
Pre-submit checklist:
Arbitraryinstances for Ledger types #6210