Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing PR #6646 #6648

Closed
wants to merge 1 commit into from
Closed

Testing PR #6646 #6648

wants to merge 1 commit into from

Conversation

kwxm
Copy link
Contributor

@kwxm kwxm commented Nov 10, 2024

This is just to check that #6646 works OK.

DO NOT MERGE!

@kwxm kwxm added Do not merge EXPERIMENT Experiments that we probably don't want to merge No Changelog Required Add this to skip the Changelog Check labels Nov 10, 2024
@kwxm
Copy link
Contributor Author

kwxm commented Nov 10, 2024

/benchmark validation

1 similar comment
@kwxm
Copy link
Contributor Author

kwxm commented Nov 10, 2024

/benchmark validation

@kwxm
Copy link
Contributor Author

kwxm commented Nov 10, 2024

/benchmark nofib

1 similar comment
@kwxm
Copy link
Contributor Author

kwxm commented Nov 10, 2024

/benchmark nofib

@kwxm
Copy link
Contributor Author

kwxm commented Nov 10, 2024

/benchmark validation

1 similar comment
@kwxm
Copy link
Contributor Author

kwxm commented Nov 10, 2024

/benchmark validation

Copy link
Contributor

Click here to check the status of your benchmark.

Copy link
Contributor

Comparing benchmark results of 'validation' on '085b74bc3' (base) and '7f71aba3d' (PR)

Results table
Script 085b74b 7f71aba Change
auction_1-1 180.9 μs 253.7 μs +40.2%
auction_1-2 657.2 μs 905.0 μs +37.7%
auction_1-3 660.2 μs 895.5 μs +35.6%
auction_1-4 267.0 μs 327.6 μs +22.7%
auction_2-1 180.7 μs 254.1 μs +40.6%
auction_2-2 642.9 μs 905.4 μs +40.8%
auction_2-3 1.182 ms 1.184 ms +0.2%
auction_2-4 898.0 μs 898.6 μs +0.1%
auction_2-5 331.3 μs 328.3 μs -0.9%
crowdfunding-success-1 300.7 μs 296.7 μs -1.3%
crowdfunding-success-2 218.8 μs 297.6 μs +36.0%
crowdfunding-success-3 219.6 μs 248.9 μs +13.3%
currency-1 261.2 μs 250.4 μs -4.1%
escrow-redeem_1-1 367.0 μs 349.7 μs -4.7%
escrow-redeem_1-2 363.6 μs 349.3 μs -3.9%
escrow-redeem_2-1 426.4 μs 410.5 μs -3.7%
escrow-redeem_2-2 426.9 μs 410.6 μs -3.8%
escrow-redeem_2-3 427.0 μs 411.6 μs -3.6%
escrow-refund-1 213.1 μs 156.7 μs -26.5%
future-increase-margin-1 356.2 μs 338.3 μs -5.0%
future-increase-margin-2 543.0 μs 763.7 μs +40.6%
future-increase-margin-3 606.6 μs 763.1 μs +25.8%
future-increase-margin-4 490.5 μs 689.6 μs +40.6%
future-increase-margin-5 846.2 μs 1.148 ms +35.7%
future-pay-out-1 261.2 μs 355.0 μs +35.9%
future-pay-out-2 565.4 μs 767.8 μs +35.8%
future-pay-out-3 562.7 μs 760.5 μs +35.2%
future-pay-out-4 845.2 μs 798.8 μs -5.5%
future-settle-early-1 305.8 μs 344.4 μs +12.6%
future-settle-early-2 770.4 μs 538.6 μs -30.1%
future-settle-early-3 768.4 μs 559.2 μs -27.2%
future-settle-early-4 741.8 μs 627.1 μs -15.5%
game-sm-success_1-1 390.1 μs 401.7 μs +3.0%
game-sm-success_1-2 203.3 μs 207.4 μs +2.0%
game-sm-success_1-3 646.1 μs 663.7 μs +2.7%
game-sm-success_1-4 237.7 μs 243.4 μs +2.4%
game-sm-success_2-1 392.4 μs 401.5 μs +2.3%
game-sm-success_2-2 202.4 μs 208.4 μs +3.0%
game-sm-success_2-3 644.8 μs 661.9 μs +2.7%
game-sm-success_2-4 237.2 μs 243.9 μs +2.8%
game-sm-success_2-5 648.4 μs 916.6 μs +41.4%
game-sm-success_2-6 237.7 μs 244.8 μs +3.0%
multisig-sm-1 397.1 μs 566.3 μs +42.6%
multisig-sm-2 387.3 μs 544.0 μs +40.5%
multisig-sm-3 391.0 μs 397.8 μs +1.7%
multisig-sm-4 397.9 μs 407.8 μs +2.5%
multisig-sm-5 556.4 μs 573.8 μs +3.1%
multisig-sm-6 396.5 μs 407.3 μs +2.7%
multisig-sm-7 386.3 μs 386.7 μs +0.1%
multisig-sm-8 558.1 μs 388.4 μs -30.4%
multisig-sm-9 561.2 μs 391.9 μs -30.2%
multisig-sm-10 792.7 μs 554.8 μs -30.0%
ping-pong-1 464.5 μs 327.4 μs -29.5%
ping-pong-2 466.3 μs 408.3 μs -12.4%
ping-pong_2-1 275.3 μs 199.0 μs -27.7%
prism-1 242.6 μs 170.1 μs -29.9%
prism-2 587.9 μs 411.9 μs -29.9%
prism-3 528.5 μs 524.4 μs -0.8%
pubkey-1 202.7 μs 202.0 μs -0.3%
stablecoin_1-1 1.072 ms 1.274 ms +18.8%
stablecoin_1-2 206.2 μs 279.0 μs +35.3%
stablecoin_1-3 1.089 ms 1.472 ms +35.2%
stablecoin_1-4 219.0 μs 296.7 μs +35.5%
stablecoin_1-5 1.401 ms 1.891 ms +35.0%
stablecoin_1-6 270.9 μs 365.1 μs +34.8%
stablecoin_2-1 939.2 μs 1.274 ms +35.6%
stablecoin_2-2 205.4 μs 207.4 μs +1.0%
stablecoin_2-3 1.086 ms 1.037 ms -4.5%
stablecoin_2-4 218.5 μs 216.5 μs -0.9%
token-account-1 196.9 μs 195.6 μs -0.7%
token-account-2 475.9 μs 347.4 μs -27.0%
uniswap-1 585.4 μs 430.2 μs -26.5%
uniswap-2 222.5 μs 228.7 μs +2.8%
uniswap-3 1.770 ms 1.826 ms +3.2%
uniswap-4 341.2 μs 351.5 μs +3.0%
uniswap-5 1.167 ms 1.199 ms +2.7%
uniswap-6 408.3 μs 331.7 μs -18.8%
vesting-1 494.4 μs 359.0 μs -27.4%
085b74b 7f71aba Change
TOTAL 39.69 ms 42.23 ms +6.4%

Copy link
Contributor

Click here to check the status of your benchmark.

Copy link
Contributor

Comparing benchmark results of 'validation' on '085b74bc3' (base) and '7f71aba3d' (PR)

Results table
Script 085b74b 7f71aba Change
auction_1-1 187.2 μs 186.0 μs -0.6%
auction_1-2 666.1 μs 661.8 μs -0.6%
auction_1-3 660.0 μs 659.0 μs -0.2%
auction_1-4 241.4 μs 241.9 μs +0.2%
auction_2-1 186.9 μs 186.5 μs -0.2%
auction_2-2 663.0 μs 661.0 μs -0.3%
auction_2-3 873.0 μs 871.1 μs -0.2%
auction_2-4 663.2 μs 659.1 μs -0.6%
auction_2-5 242.6 μs 241.2 μs -0.6%
crowdfunding-success-1 219.0 μs 218.1 μs -0.4%
crowdfunding-success-2 219.9 μs 218.7 μs -0.5%
crowdfunding-success-3 219.9 μs 218.6 μs -0.6%
currency-1 263.0 μs 353.3 μs +34.3%
escrow-redeem_1-1 366.0 μs 498.6 μs +36.2%
escrow-redeem_1-2 366.3 μs 496.7 μs +35.6%
escrow-redeem_2-1 428.4 μs 584.0 μs +36.3%
escrow-redeem_2-2 427.7 μs 580.5 μs +35.7%
escrow-redeem_2-3 428.3 μs 580.0 μs +35.4%
escrow-refund-1 164.0 μs 223.1 μs +36.0%
future-increase-margin-1 261.1 μs 260.3 μs -0.3%
future-increase-margin-2 574.5 μs 556.1 μs -3.2%
future-increase-margin-3 642.5 μs 541.5 μs -15.7%
future-increase-margin-4 570.2 μs 509.2 μs -10.7%
future-increase-margin-5 818.4 μs 841.4 μs +2.8%
future-pay-out-1 251.4 μs 260.6 μs +3.7%
future-pay-out-2 544.1 μs 731.2 μs +34.4%
future-pay-out-3 543.1 μs 770.3 μs +41.8%
future-pay-out-4 814.6 μs 1.145 ms +40.6%
future-settle-early-1 252.5 μs 292.3 μs +15.8%
future-settle-early-2 543.1 μs 767.2 μs +41.3%
future-settle-early-3 541.0 μs 767.7 μs +41.9%
future-settle-early-4 608.5 μs 858.5 μs +41.1%
game-sm-success_1-1 555.5 μs 551.8 μs -0.7%
game-sm-success_1-2 287.8 μs 212.6 μs -26.1%
game-sm-success_1-3 909.4 μs 639.8 μs -29.6%
game-sm-success_1-4 336.1 μs 235.8 μs -29.8%
game-sm-success_2-1 550.5 μs 389.7 μs -29.2%
game-sm-success_2-2 286.7 μs 202.0 μs -29.5%
game-sm-success_2-3 903.4 μs 644.7 μs -28.6%
game-sm-success_2-4 335.7 μs 236.2 μs -29.6%
game-sm-success_2-5 910.1 μs 657.0 μs -27.8%
game-sm-success_2-6 337.1 μs 271.6 μs -19.4%
multisig-sm-1 563.1 μs 418.7 μs -25.6%
multisig-sm-2 547.4 μs 399.5 μs -27.0%
multisig-sm-3 553.2 μs 404.7 μs -26.8%
multisig-sm-4 480.6 μs 411.9 μs -14.3%
multisig-sm-5 789.6 μs 552.1 μs -30.1%
multisig-sm-6 451.4 μs 394.8 μs -12.5%
multisig-sm-7 386.0 μs 386.2 μs +0.1%
multisig-sm-8 554.6 μs 390.5 μs -29.6%
multisig-sm-9 560.7 μs 397.3 μs -29.1%
multisig-sm-10 549.9 μs 640.3 μs +16.4%
ping-pong-1 329.3 μs 327.7 μs -0.5%
ping-pong-2 328.6 μs 330.1 μs +0.5%
ping-pong_2-1 287.5 μs 201.4 μs -29.9%
prism-1 243.3 μs 224.6 μs -7.7%
prism-2 588.4 μs 588.6 μs +0.0%
prism-3 526.4 μs 368.3 μs -30.0%
pubkey-1 202.7 μs 202.1 μs -0.3%
stablecoin_1-1 1.281 ms 899.9 μs -29.8%
stablecoin_1-2 194.7 μs 249.2 μs +28.0%
stablecoin_1-3 1.044 ms 1.087 ms +4.1%
stablecoin_1-4 216.6 μs 298.4 μs +37.8%
stablecoin_1-5 1.348 ms 1.834 ms +36.1%
stablecoin_1-6 260.0 μs 278.2 μs +7.0%
stablecoin_2-1 904.7 μs 941.8 μs +4.1%
stablecoin_2-2 198.2 μs 205.2 μs +3.5%
stablecoin_2-3 1.042 ms 1.089 ms +4.5%
stablecoin_2-4 210.8 μs 225.8 μs +7.1%
token-account-1 257.0 μs 268.8 μs +4.6%
token-account-2 457.2 μs 476.4 μs +4.2%
uniswap-1 585.6 μs 513.0 μs -12.4%
uniswap-2 316.4 μs 232.1 μs -26.6%
uniswap-3 2.510 ms 2.566 ms +2.2%
uniswap-4 485.0 μs 483.7 μs -0.3%
uniswap-5 1.646 ms 1.644 ms -0.1%
uniswap-6 457.8 μs 456.2 μs -0.3%
vesting-1 493.7 μs 493.0 μs -0.1%
085b74b 7f71aba Change
TOTAL 41.71 ms 41.56 ms -0.4%

Copy link
Contributor

Click here to check the status of your benchmark.

@kwxm
Copy link
Contributor Author

kwxm commented Nov 10, 2024

These results are terrible, but fortunately I think we were doing the wrong thing. I'm going to try again.

Copy link
Contributor

Comparing benchmark results of 'nofib' on '085b74bc3' (base) and '7f71aba3d' (PR)

Results table
Script 085b74b 7f71aba Change
clausify/formula1 3.180 ms 4.371 ms +37.5%
clausify/formula2 4.248 ms 5.851 ms +37.7%
clausify/formula3 11.61 ms 15.97 ms +37.6%
clausify/formula4 26.55 ms 36.54 ms +37.6%
clausify/formula5 56.01 ms 77.10 ms +37.7%
knights/4x4 18.40 ms 24.29 ms +32.0%
knights/6x6 48.44 ms 43.38 ms -10.4%
knights/8x8 108.0 ms 82.95 ms -23.2%
primetest/05digits 14.89 ms 10.61 ms -28.7%
primetest/10digits 29.13 ms 21.41 ms -26.5%
primetest/30digits 80.58 ms 64.70 ms -19.7%
primetest/50digits 109.0 ms 106.8 ms -2.0%
queens4x4/bt 5.595 ms 5.428 ms -3.0%
queens4x4/bm 7.035 ms 6.849 ms -2.6%
queens4x4/bjbt1 6.783 ms 6.580 ms -3.0%
queens4x4/bjbt2 6.358 ms 6.163 ms -3.1%
queens4x4/fc 14.28 ms 13.85 ms -3.0%
queens5x5/bt 75.97 ms 73.63 ms -3.1%
queens5x5/bm 107.2 ms 76.73 ms -28.4%
queens5x5/bjbt1 88.79 ms 98.97 ms +11.5%
queens5x5/bjbt2 86.21 ms 118.4 ms +37.3%
queens5x5/fc 181.6 ms 176.2 ms -3.0%
085b74b 7f71aba Change
TOTAL 1.090 s 1.077 s -1.2%

@kwxm
Copy link
Contributor Author

kwxm commented Nov 10, 2024

Tying again in #6650. It's impressive just how bad these results are though.

@kwxm kwxm closed this Nov 10, 2024
@kwxm kwxm reopened this Nov 12, 2024
@kwxm
Copy link
Contributor Author

kwxm commented Nov 12, 2024

Reopening this so I can observe what's happening on the machine.

@kwxm
Copy link
Contributor Author

kwxm commented Nov 12, 2024

/benchmark validation

Copy link
Contributor

Click here to check the status of your benchmark.

@kwxm
Copy link
Contributor Author

kwxm commented Nov 12, 2024

Nope. The base branch has vanished, so this won't work.

@kwxm kwxm closed this Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Do not merge EXPERIMENT Experiments that we probably don't want to merge No Changelog Required Add this to skip the Changelog Check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant