Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tasty-papi benchmarking #6674

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

papagvas
Copy link

Implementation of tasty-papi benchmarks as requested here: #6004

@zeme-wana zeme-wana added the No Changelog Required Add this to skip the Changelog Check label Nov 22, 2024
Copy link
Contributor

@effectfully effectfully left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only needs the commented out code to get removed.

Build seems broken though. @zeme-wana could you please look into it?

benchTermCek evalCtx term =
let !term' = force term
in whnf (evaluateCekForBench evalCtx) term'
-}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commented out code.

Run the benchmarks. You can run groups of benchmarks by typing things like
`stack bench -- plutus-benchmark:validation --ba crowdfunding`
or
`cabal bench -- plutus-benchmark:validation --benchmark-options crowdfunding`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will that --benchmark-options thing work for PAPI benchmarks as well or is it just copy-pasta?

ingredients = includingOptions customOpts : benchIngredients

mkCekBM file program =
benchTermCek evalCtx . toNamedDeBruijnTerm . UPLC._progTerm $ unsafeUnflat file program
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, why are we even including the cost of unflat here? And in the original validation benchmarks. That should be discussed separately, not a blocker for this PR.

@effectfully
Copy link
Contributor

/benchmark validation

Copy link
Contributor

Click here to check the status of your benchmark.

@zeme-wana
Copy link
Contributor

@papagvas Can you please rebase off of master? This will fix the ci/eval build error. Thanks!

@papagvas
Copy link
Author

oops, I can't read apparently

@zeme-wana
Copy link
Contributor

oops, I can't read apparently

Thanks. There are still build errors. I'm looking into this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No Changelog Required Add this to skip the Changelog Check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants