Skip to content

Commit

Permalink
fixup: fix deps and lints
Browse files Browse the repository at this point in the history
  • Loading branch information
mcous committed Aug 3, 2024
1 parent 454f22d commit 57d570f
Show file tree
Hide file tree
Showing 8 changed files with 45 additions and 215 deletions.
8 changes: 7 additions & 1 deletion .eslintrc.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,13 @@ rules:
jsdoc/tag-lines: "off"
"@typescript-eslint/restrict-template-expressions":
- "error"
- allowNumber: true
- allowAny: false
allowBoolean: false
allowNullish: false
allowNumber: true
allowRegExp: false
allowNever: false
"@typescript-eslint/no-unnecessary-type-parameters": "off"

overrides:
- files: ["**/*.js"]
Expand Down
5 changes: 4 additions & 1 deletion .github/dependabot.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,13 @@ updates:
development:
dependency-type: "development"

# TODO(mcous, 2024-07-06): update to ESLint v9 + flat config
ignore:
# TODO(mcous, 2024-07-06): update to ESLint v9 + flat config
- dependency-name: "eslint"
versions: [">=9"]
# rimraf dropped support for ESLint v18
- dependency-name: "rimraf"
versions: [">=6"]

# Update GitHub Actions dependencies
- package-ecosystem: "github-actions"
Expand Down
2 changes: 1 addition & 1 deletion action.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/* eslint-disable @typescript-eslint/no-floating-promises, @typescript-eslint/no-unsafe-assignment, @typescript-eslint/no-unsafe-call */
/* eslint-disable @typescript-eslint/no-floating-promises, @typescript-eslint/no-require-imports, @typescript-eslint/no-unsafe-assignment, @typescript-eslint/no-unsafe-call */
"use strict";

const { main } = require("./dist/main.js");
Expand Down
2 changes: 1 addition & 1 deletion bin/npm-publish.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#!/usr/bin/env node
/* eslint-disable @typescript-eslint/use-unknown-in-catch-callback-variable, unicorn/prefer-module, unicorn/prefer-top-level-await */
/* eslint-disable @typescript-eslint/no-require-imports, @typescript-eslint/use-unknown-in-catch-callback-variable, unicorn/prefer-module, unicorn/prefer-top-level-await */
"use strict";

const process = require("node:process");
Expand Down
4 changes: 2 additions & 2 deletions dist/main.js.map

Large diffs are not rendered by default.

235 changes: 28 additions & 207 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@
"eslint-plugin-unicorn": "^55.0.0",
"prettier": "^3.0.3",
"prettier-plugin-jsdoc": "^1.1.1",
"rimraf": "^6.0.1",
"rimraf": "^5.0.9",
"typescript": "^5.2.2",
"vitest": "^2.0.5",
"vitest-when": "^0.4.0"
Expand Down
2 changes: 1 addition & 1 deletion src/compare-and-publish/compare-and-publish.ts
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ export async function compareAndPublish(
const isDryRun = options.dryRun.value;
const comparison = compareVersions(version, viewCall.successData, options);
const publishCall =
comparison.type ?? isDryRun
(comparison.type ?? isDryRun)
? await callNpmCli(PUBLISH, publishArguments, cliOptions)
: { successData: undefined, errorCode: undefined, error: undefined };

Expand Down

0 comments on commit 57d570f

Please sign in to comment.