Fix(VIM-3695): Wrap getting a vimLeadSelectionOffset with a read action

JetBrains · Nov 15, 2024 · 0e3cda8 · 0e3cda8
1 parent ed2fe3d
commit 0e3cda8
Showing 1 changed file with 8 additions and 4 deletions.
diff --git a/vim-engine/src/main/kotlin/com/maddyhome/idea/vim/api/VimVisualMotionGroupBase.kt b/vim-engine/src/main/kotlin/com/maddyhome/idea/vim/api/VimVisualMotionGroupBase.kt
@@ -162,10 +162,14 @@ abstract class VimVisualMotionGroupBase : VimVisualMotionGroup {
     val autodetectedSubMode = subMode ?: autodetectVisualSubmode(editor)
     editor.mode = Mode.VISUAL(autodetectedSubMode)
     //    editor.vimStateMachine.setMode(VimStateMachine.Mode.VISUAL, autodetectedSubMode)
-    if (autodetectedSubMode == SelectionType.BLOCK_WISE) {
-      editor.primaryCaret().run { vimSelectionStart = vimLeadSelectionOffset }
-    } else {
-      editor.nativeCarets().forEach { it.vimSelectionStart = it.vimLeadSelectionOffset }
+
+    // vimLeadSelectionOffset requires read action
+    injector.application.runReadAction {
+      if (autodetectedSubMode == SelectionType.BLOCK_WISE) {
+        editor.primaryCaret().run { vimSelectionStart = vimLeadSelectionOffset }
+      } else {
+        editor.nativeCarets().forEach { it.vimSelectionStart = it.vimLeadSelectionOffset }
+      }
     }
     return true
   }