Enable lookahead for argument text object #1031
Open
+193
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lippfi
reviewed
Nov 22, 2024
src/main/java/com/maddyhome/idea/vim/extension/argtextobj/VimArgTextObjExtension.java
Outdated
Show resolved
Hide resolved
lippfi
reviewed
Nov 22, 2024
| --leftBound; | ||
| } else if (brackets.isOpenBracket(ch)) { | ||
| ++rightBound; |
There was a problem hiding this comment.
Th else branch will do the same, do we need this?
|
The lookahead doesn't always work |
lippfi
requested changes
Nov 22, 2024
|
@lippfi Good catch with that failing example. I've made some fixes, which should address that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows motions like
caaordiato look ahead for potential arguments, say when the caret is positioned before the list of arguments. This would work similar to https://github.com/vim-scripts/argtextobj.vim and to standard motions likeci".