feat(client): add custom prefix support to the Client library #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fortuna
approved these changes
Oct 21, 2022
client/salt.go
Outdated
| // | ||
| // Note: Prefixes steal entropy from the initialization vector. This weakens | ||
| // security by increasing the likelihood that the same IV is used in two | ||
| // different connections (which becomes likely once 2^-N/2 connections are |
There was a problem hiding this comment.
Is that 2^(-N/2)? That doesn't seem right.
added 2 commits
October 21, 2022 12:58
fortuna
approved these changes
Oct 21, 2022
|
Implementing this solely on the client side will lead to misuse by users that server administrators have no means to detect or stop. See shadowsocks/shadowsocks-org#204. |
fortuna
changed the title
fortuna
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.