Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Meow_Float typedef and set it to a float #11

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

DragoonAethis
Copy link

This allows library users to easily swap the type used by meow_fft to
something more accurate (doubles or long doubles). The default float
type is kept for backwards compatibility.

This allows library users to easily swap the type used by meow_fft to
something more accurate (doubles or long doubles). The default float
type is kept for backwards compatibility.
@JodiTheTigger
Copy link
Owner

Thanks for the PR. I'll check it out fully when I get time, but on the surface I don't see anything wrong with it.

@JodiTheTigger
Copy link
Owner

Trying to get it to work on the development branch when set to double but I keep getting stack smash exceptions. I'll keep looking at it.

@DragoonAethis
Copy link
Author

Not sure what's going on... I needed this a while ago for this patchset on IGT but it wasn't merged or even reviewed in the end so it didn't go anywhere further. For reference, the usage is in this patch, maybe it'll help figuring out if it's a usage or the library problem. Sorry :/

@JodiTheTigger
Copy link
Owner

Hey - not a problem :-)

My development branch could be improved quite a bit, along with the code in general (memory safety, sanitizer builds, naming, alignment, etc)

If I can generalize the data size I might play with 16 bit floats and other stuff just for fun.

but first - double...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants