fix: selecting terminal blocks should focus the split

slug/protocol/pipeTransport.js

@@ -63,7 +63,12 @@ class PipeTransport {
   sendString(messageStr) {
     if (this._closed)
       throw new Error('Pipe has been closed');
-    this._pipeWrite.write(messageStr);
+    this._pipeWrite.write(messageStr, err => {
+      if (err) {
+        console.error('pipe write error', err);
+        console.error('trying to write', messageStr);
+      }
+    });
     this._pipeWrite.write('\0');
   }
 

src/TerminalBlock.ts

@@ -36,6 +36,7 @@ export class TerminalBlock implements LogItem {
   constructor(delegate: TerminalBlockDelegate) {
 
     this.element = document.createElement('div');
+    this.element.classList.add('terminal-block');
     this.element.style.height = '0px';
     this.element.style.overflow = 'hidden';
     this._terminal = new Terminal({
@@ -76,6 +77,17 @@ export class TerminalBlock implements LogItem {
         callback: () => navigator.clipboard.writeText(this._terminal.getSelection()),
       }], event);
     });
+    this.element.addEventListener('mousedown', event => {
+      // xterm default prevents the mousedown to stop browser selection
+      // But this stops focus from moving to the disabled terminal, which is bad
+      if (!event.defaultPrevented || this._terminal.enabled)
+        return;
+      this.element.setAttribute('tabindex', '-1');
+      this.element.focus();
+    });
+    this.element.addEventListener('focusout', () => {
+      this.element.removeAttribute('tabindex');
+    });
     this._terminal.open(this.element);
     this._terminal.loadAddon(this._addon);
 

src/shell.css

@@ -140,3 +140,7 @@ body:not(.vscode-dark) iframe.fullscreen {
 .terminal.xterm .xterm-viewport {
   overflow: hidden;
 }
+
+.terminal-block:focus {
+  outline: none;
+}