Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CatBoostRegressor.subsample should be Float64 #36

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

liuyxpp
Copy link

@liuyxpp liuyxpp commented Mar 25, 2024

According to CatBoost doc, it should be a floating number in the range (0, 1].

The proof is if you set an integer larger than 1 to subsample and train, you will get the error:

Python: CatBoostError: /src/catboost/catboost/private/libs/options/bootstrap_options.cpp:5: Subsample should be in (0,1]

@ericphanson
Copy link
Collaborator

Can you add a test that uses the functionality? To ensure we don’t regress

@ablaom
Copy link
Member

ablaom commented Jun 18, 2024

@liuyxpp any chance of adding that test?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants