-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v1.0 #255
Merged
Merged
v1.0 #255
Changes from 24 commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
ef6234d
Compact show for `BlockRange` (#248)
jishnub 27bc4e1
Merge branch 'master' into release-1.0
jishnub 3fb6573
Fetch changes to convert for BlockedUnitRange
jishnub ab3dce9
Merge branch 'master' into release-1.0
jishnub aab5fa8
Merge branch 'master' into release-1.0
jishnub 222a79a
Merge branch 'master' into release-1.0
jishnub 9d8a552
Bump version to v1.0.0-dev
jishnub 3c352fa
Merge branch 'master' into release-1.0
jishnub c89df62
Merge branch 'master' into release-1.0
jishnub 7766ac9
Merge branch 'master' into release-1.0
jishnub 4ee907e
Add `BlockedOneTo` as the axis type for a `BlockedArray` (#348)
jishnub 94e7ca3
Infinite broadcast tests (#383)
jishnub 4a7b1df
Specialize blockedrange BroadcastStyle for LazyArrayStyle (#384)
jishnub 6987f0b
Merge branch 'master' into release-1.0
jishnub b361279
Define dataids for PseudoBlockArrays (#364) (#385)
jishnub d02efe6
Banded Matrix extension (#388)
dlfivefifty 8639776
Generalize the element type of `BlockedUnitRange` (#337)
mtfishman 465569a
Allow non-Int eltypes in BlockedOneTo (#395)
jishnub e3e69c7
Move LazyArrays extension to LazyArrays.jl (#393)
dlfivefifty 928dea7
Use FillArrays accumulate overloads (#397)
dlfivefifty ee57d11
Redefine blocksizes (#399)
mtfishman 3c9abe3
Rename PseudoBlockArray to BlockedArray (#401)
mtfishman 8621223
v1.0, add README
dlfivefifty 11e1f26
rename files
dlfivefifty 70e6e02
Update README.md
dlfivefifty File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -9,4 +9,5 @@ src/.DS_Store | |
Manifest.toml | ||
Manifest-v*.*.toml | ||
.DS_Store | ||
.*.swp | ||
build |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
module BlockArraysBandedMatricesExt | ||
|
||
using BandedMatrices, BlockArrays | ||
using BlockArrays.ArrayLayouts | ||
import BandedMatrices: isbanded, AbstractBandedLayout, bandeddata, bandwidths | ||
import BlockArrays: blockcolsupport, blockrowsupport, AbstractBlockedUnitRange | ||
import ArrayLayouts: sub_materialize | ||
|
||
|
||
bandeddata(P::BlockedMatrix) = bandeddata(P.blocks) | ||
bandwidths(P::BlockedMatrix) = bandwidths(P.blocks) | ||
|
||
function blockcolsupport(::AbstractBandedLayout, B, j) | ||
m,n = axes(B) | ||
cs = colsupport(B,n[j]) | ||
findblock(m,first(cs)):findblock(m,last(cs)) | ||
end | ||
|
||
function blockrowsupport(::AbstractBandedLayout, B, k) | ||
m,n = axes(B) | ||
rs = rowsupport(B,m[k]) | ||
findblock(n,first(rs)):findblock(n,last(rs)) | ||
end | ||
|
||
# ambiguity | ||
sub_materialize(::AbstractBandedLayout, V, ::Tuple{AbstractBlockedUnitRange,Base.OneTo{Int}}) = BandedMatrix(V) | ||
sub_materialize(::AbstractBandedLayout, V, ::Tuple{Base.OneTo{Int},AbstractBlockedUnitRange}) = BandedMatrix(V) | ||
|
||
|
||
end |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other things to potentially mention:
blocksizes(array::AbstractArray)
is changed fromblocklengths.(axes(array))
to an iterator of sizeblocksize(array)
over the sizes of each block ofarray
.BlockedUnitRange
is now parametrized by the element type instead of hardcoded toInt
.