Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove unnecessary @time in tests #3394

Merged
merged 1 commit into from
Oct 21, 2023
Merged

remove unnecessary @time in tests #3394

merged 1 commit into from
Oct 21, 2023

Conversation

bkamins
Copy link
Member

@bkamins bkamins commented Oct 21, 2023

I must have left these @time calls by mistake. They are not needed. Tests.jl reports time of running @testset anyway.

@bkamins bkamins added the ecosystem Issues in DataFrames.jl ecosystem label Oct 21, 2023
@bkamins bkamins added this to the 1.7 milestone Oct 21, 2023
@bkamins bkamins merged commit 8c32d53 into main Oct 21, 2023
6 of 7 checks passed
@bkamins bkamins deleted the bk/clean_tests branch October 21, 2023 21:06
@bkamins
Copy link
Member Author

bkamins commented Oct 21, 2023

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nalimilan nalimilan nalimilan approved these changes

@pdeffebach pdeffebach Awaiting requested review from pdeffebach

Assignees
No one assigned
Labels
ecosystem Issues in DataFrames.jl ecosystem
Projects
None yet
Milestone
1.7
Development

Successfully merging this pull request may close these issues.
2 participants
@bkamins @nalimilan