add sortrows and sortcols to unstack #3395
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
storopoli
reviewed
Nov 21, 2023
| @@ -259,6 +260,14 @@ Row and column keys are ordered in the order of their first appearance. | |||
| time). Whether or not tasks are actually spawned and their number are | |||
| determined automatically. Set to `false` if `combine` requires serial | |||
| execution or is not thread-safe. | |||
| - `sortrows`: the order of rows in the output table; all values accepted by | |||
There was a problem hiding this comment.
Suggested change
| - `sortrows`: the order of rows in the output table; all values accepted by | |
| - `sortrows`: the order of rows in the resulting table; all values accepted by |
I prefer something else than "output", I find it a little ambiguous.
| - `sortrows`: the order of rows in the output table; all values accepted by | ||
| `sort` keyword argument in `groupby` passed the `rowkeys` for grouping are supported; | ||
| `false` by default (rows are ordered following the first appereance order). | ||
| - `sortcols`: the order of columns in the output table; all values accepted by |
There was a problem hiding this comment.
Suggested change
| - `sortcols`: the order of columns in the output table; all values accepted by | |
| - `sortcols`: the order of columns in the resulting table; all values accepted by |
I prefer something else than "output", I find it a little ambiguous.
| @@ -259,6 +260,14 @@ Row and column keys are ordered in the order of their first appearance. | |||
| time). Whether or not tasks are actually spawned and their number are | |||
| determined automatically. Set to `false` if `combine` requires serial | |||
| execution or is not thread-safe. | |||
| - `sortrows`: the order of rows in the output table; all values accepted by | |||
| `sort` keyword argument in `groupby` passed the `rowkeys` for grouping are supported; | |||
| `sort` keyword argument in `groupby` passed the `rowkeys` for grouping are supported; | ||
| `false` by default (rows are ordered following the first appereance order). | ||
| - `sortcols`: the order of columns in the output table; all values accepted by | ||
| `sort` keyword argument in `groupby` passed `colkey` for grouping are supported; |
Comment on lines
+269
to
+270
| Note that the ordering is done on the source data (not on column final column names | ||
| that can be potentially changed by the function passed in the `renamecols` keyword argument). |
There was a problem hiding this comment.
This is also confusing.
"column final column names"
|
@storopoli - thank you for the comments. @nalimilan - before I move forward could you please comment if you like this addition. (I would want to have a decision on this PR and a few more and make a release in 1Q2024 of DataFrames.jl, especially that Julia 1.10 is coming and we need to clean up Project.toml in light of the change how standard library packages will be handled there) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3334
Tests are missing, but I would like to get feedback if we like the design before I move forward.
This is useful as the order of appearance is often not wanted. And it is impossible to ensure wanted sort order of rows and columns in the source. Finally, especially for columns - it is especially useful if you have ordered categorical values to present (so you can sort data e.g. by day of week, which is lost after you created the output since column names are
Symbolthen)