Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for Documenter.jl v1 and Julia v1.10 #3416

Merged
merged 5 commits into from
Jan 19, 2024

Conversation

hyrodium
Copy link
Contributor

No description provided.

docs/make.jl Show resolved Hide resolved
@bkamins bkamins added the doc label Jan 10, 2024
@bkamins bkamins added this to the 1.7 milestone Jan 10, 2024
@bkamins
Copy link
Member

bkamins commented Jan 10, 2024

Thank you!

@hyrodium
Copy link
Contributor Author

Oh, the documentation action uses Julia v1.9?
I couldn't find a version specification in .github/workflows/ci.yml.

@@ -11,4 +11,5 @@ Statistics = "10745b16-79ce-11e8-11f9-7d13ad32a3b2"
Tables = "bd369af6-aec1-5ad0-b16a-f7cc5008161c"

[compat]
Documenter = "0.27"
Documenter = "1"
julia = "1.10" # For jldoctest
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know why this is required? Do you know how to use the latest stable release? (so that we do not have to update this file with every Julia release?)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know why this is required? Do you know how to use the latest stable release?

Actually, I don't know. Perhaps caches are related and adding the julia compat resolved the version, I guess.

so that we do not have to update this file with every Julia release?)

This compat also accepts v1.11 and higher, so we don't have to update with every Julia release.
This entry should be updated when REPL outputs are changed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This entry should be updated when REPL outputs are changed.

This is the issue - we will not know if they had changed if we fix Julia version here.

@bkamins bkamins merged commit d45c99a into JuliaData:main Jan 19, 2024
6 of 7 checks passed
@bkamins
Copy link
Member

bkamins commented Jan 19, 2024

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants